Running dev versions of ctools, views, date and entity with caches flushed x2. Apart from having the ungrouped bug on summary views (#1207540: Inappropriately ungrouped display summary of content date field. ), I am now also getting this error. 

 Notice: Undefined property: date_views_argument_handler_simple::$name_alias in views_handler_argument->summary_sort() (line 853 of /var/www/sites/all/modules/views/handlers/views_handler_argument.inc).

 Debug: 'Exception: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near \'FROM 
node node
WHERE (( (node.status = \'1\') AND (node.type IN  (\'abstracts_n_po\' at line 1'
in views_plugin_query_default->execute() (line 1388 of /var/www/sites/all/modules/views/plugins/views_plugin_query_default.inc).

I have traced it to changes done during this particular commit for #1147620: Multi-day events don't show up on day view of spanned days. as the dev tree prior to this processes as per normal.

CommentFileSizeAuthor
#10 date_1227350.patch753 bytesgrendzy

Comments

pwaak’s picture

pwaak commented

I am getting this error with PHP 5.2.17.

karens’s picture

karens commented

The commit adds "@TODO Need to write a custom query here, the parent query won't work." in the summary_query() function, so yes, this needs to be fixed.

karens’s picture

karens commented
Status: Active » Fixed

Fixed in latest dev.

Fajan’s picture

Fajan commented

Thanks! Can confirm that both problems are fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

stockliasteroid’s picture

stockliasteroid commented

This appears to be broken again in -dev as of 2011-Sep-08. I'm getting the exact same errors above for my summary block view.

idmacdonald’s picture

idmacdonald commented
Status: Closed (fixed) » Active

I am also getting this error, using the 7.x-2.x-dev version of the module from 2011-09-08. Seems like there must have been a regression somewhere.

idmacdonald’s picture

idmacdonald commented

I can confirm that rolling back date_views_argument_handler_simple.inc to the version from commit 0756269 (2011-07-24) seems to solve the problem. So, it looks like there has been some regression since then.

grendzy’s picture

grendzy commented

Here is the commit that introduce the regression:
http://drupalcode.org/project/date.git/commitdiff/f2e8fdbf479e0798be72c0...

grendzy’s picture

grendzy commented
Status: Active » Needs review
StatusFileSize
new date_1227350.patch753 bytes

I think that summary_query() should not call date_forbid() at all - since by definition the summary is only invoked when no argument is present.

karens’s picture

karens commented
Status: Needs review » Fixed

I agree with your assessment. Fixed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.