ppokrivcak [ppokrivcak]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site using the proposed theme; for modules, it should include also a comparison with the existing solutions.

I am adding the tag we are using for Ubercart related modules.

What does this offer that the existing Ubercart Affiliate module (uc_affiliate2) doesn't, apart from requiring a commercial application (Post Affiliate Pro)?

• This is a partial review.
• The points reported in this review are not in order of importance / relevance.
• Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
• Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.

1. License files cannot be committed in Drupal.org repository. Projects committed in Drupal.org repository have the same license used by Drupal.

2. version = "6.x-1.0"
   core = "6.x"
   project = "post_affiliate_pro"
   datestamp = "1259710167"
   
   

   Those lines (except the second one) must be removed.

3. Menu descriptions and titles, as well as schema descriptions, are not passed to t().
4. The module doesn't implement hook_uninstall().
5. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see hoe Drupal variables, global variables, constants, and functions defined from the module should be named; how the code should be formatted.

6. 			$output .= t("This module is for merchants (eshop owners) who want to increas their income using external affiliate application.<br/>") ;
   			$output .= t("<p>Merchant needs to have valid account at <a href=\"http://www.qualityunit.com/postaffiliatepro/#drupal\" target=\"_blank\" title=\"Post Affiliate Pro\">Post Affiliate Pro</a> or can try 'demo' account,
   			that you get by default after Post affiliate Pro (PAP) module installation. <br/> With this account you can test all available functions of this module.<br/>
   
   

   Use a placeholder for URLs within a string passed to t().
   Avoid to escape a string delimiter inside a string, especially if the string is passed to t().
   When possible, avoid also to insert HTML tags inside a string to translate, especially if the tags are at the beginning (or at the end) of the string. This doesn't mean that a sentence must be split into phrases just to avoid to include HTML tags into a string passed to t().

7. Permissions follow the schema <verb> <object>, where the verb is written in lowercase; the schema is not followed by affiliate uc_post_affiliate_pro.
8. Strings used in the user interface should be translated. There are strings that are partially translated.

9. 	'#description' => t('Whether can user become an Affiliate(1) or no(0) by user registration or user account update.'),
   
   

   The values 1 and 0 are not visible to the users; the reference to those values is not important for the users.

10. /*function uc_post_affiliate_admin_manage_validate($form, &$form_state) {
    $url = $form_state['values']['merchant_url_prefix'];
    
    if (!empty($url) && ($url != check_url($url) || strpos($url, '://') !== FALSE)) {
    form_set_error('affiliate_invalid_redirect', t('Please enter a valid Url path, with the http or htts at the beginning.'));
    }
    }*/
    
    

    The presence of commented out code makes me think the module is not complete; the CVS application requirements reports that an application should be done with a complete module.

11. 					// The subject is displayed at the top of the block. Note that it
    					// should be passed through t() for translation.
    					$block['subject'] = t('Register as our new affiliate now!');
    
    

    What is reported by the comment is true for every string that is used in the user interface; what reported by the comment is not relevant.

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.