migala [migala]

Hello, and thanks for applying for a CVS account.

There are already modules to fight spam with CAPTCHAs; why didn't you open a feature request for one of them?

I see it more like a new feature that can be added to an existing project.

Anyway, the CVS application cannot proceed, until you do not provide something necessary.

• The points reported in this review are not in order or importance / relevance.
• Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
• Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.

1. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be formatted.

2. 				$captcha=array();
   				$captcha['solution']=$ac_result;
   				$img_src = check_url(url("noun_captcha/$captcha_sid/". time()));
   
   

   It's not clear to me how that code would work, and use the correct image.

3. 	var_dump($image);die();
   

   Remove any debug code.

4. The module doesn't implement hook_uninstall() to remove the Drupal variables it defines.

5. 		$file_format = variable_get('noun_captcha_file_format', noun_captcha_FILE_FORMAT_JPG);
   		if ($file_format == noun_captcha_FILE_FORMAT_JPG) {
   

   The constant has not been defined.

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.