veracium [veracium]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module/theme; for modules it should include also a comparison with the existing solutions, while for themes a screenshot is also required.

Thanks for the reply.

Hi,

First: http://drupal.org/coding-standards. I always stress this point, but I think it's important that Drupal has a coherent, clean code repository (otherwise no-one would have bothered to write that guide in the first place). It's easier for everyone to find their way when all the code is formatted the same way.

Second, this only works for the body, not for any CCK or custom fields. This is not a blocker of course, but will you consider that for the future as well ? Because this is particularly important for e-commerce like sites. And their images are not likely to be found inside the body field.
[edit: I see that you've put a ToDo list in your code for this]

Otherwise, the code works fine. Good job

I take the status has not been correctly set.

@kiamlaluno

Oops, sorry :-). I thought it was ok. But when can we set it to R&TBTC ? Or can only admins do that ? Cause I've set another one as well (http://drupal.org/node/798960)...

1. See http://drupal.org/coding-standards to understand how a module should be written. In particular see how functions, Drupal variables, global variables, and constants defined from the module should be named; see how the code should be formatted.

2. /**
    * Implementation of hook_nodeapi()
    */
   function escape_string_for_regex($str)
   {
   

   The comment is wrong.

@wadmiraal: It's fine if you set the status to reviewed & tested from the community, but not if the code doesn't respect the namespace. :-)

@kiamlaluno

Ok, got it :-)

What is the status of this module? I'm stuck waiting for a fix to this problem before I can go live with my store.

@billynytro

Well, if you're really in a hurry, you can always download the alpha version with the first comment, but I wouldn't if I were you :-). Besides, this only works for images inside the body. If you have images for your products in any other field (like CCK), it won't solve the problem (yet - because it is not actually that difficult to get it to work for CCK fields. Just a little hook_nodeapi() on 'validate' and just update all "filefield" type fields...)

subscribing

subscribing

Made a module to fix this problem for a project a few years ago, and finally got round to putting it up on my site.

Too lazy to upload it here and don't have the time to maintain/bugfix at the moment.

http://www.arricc.net/drupal-https-images.php