CVS edit link for dariusa

I am Darius Alavi a web developer and programmer from Denver, Colorado. I have been a Drupal developer for roughly four years. I work for eCollege and have been developing a good amount of modules for our internal website, which is in Drupal. I recently created a module that allows for bulk emails to be sent to all users on a Drupal site. This is a fairly simple module but most likely something a good amount of Drupal users would need.

I would like to eventually add to this module and allow mailing by roles and other options. This is the first module I would like to submit and maintain. Eventually, I would like to maintain other modules. One more advanced module I am currently working on, I would like to submit and maintain is a module that allows for the mass creation of image pages. I all ready have this module installed and working on my work's internal website as well as my own personally internet photo album. The next steps would be to make it more generic so as to be used straight from installation onto any Drupal website. Surprisingly, I cannot find a bulk email module and so this would be new and, in my opinion, much needed functionality to many Drupal sites.

CommentFileSizeAuthor
#1 bulk_mailer.zip1.73 KBdariusa

Comments

dariusa’s picture

dariusa commented
StatusFileSize
new bulk_mailer.zip1.73 KB

This module is still in it's basic form; as explained above I would like to expand it to include additional features. I would also like to incorporate user feedback into the module.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Needs work
Issue tags: +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module/theme; for modules it should include also a comparison with the existing solutions, while for themes a screenshot is also required. In particular, what is the difference with http://drupal.org/project/mailout, or http://drupal.org/project/simplenews? Could not the differences be added to the existing projects?

dariusa’s picture

dariusa commented

Hi kiamlaluno!

Thanks for the reply and letting me know some volunteers will review my code. I will get to expanding the motivation message tonight after work going off your advice above.

Thanks!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Remember that is not possible to change the text you already used as motivation message, and you need to write the expanded motivation message in a comment.

dariusa’s picture

dariusa commented

Thanks for the heads up! I will write the expanded motivation here:

The features for this proposed module are currently rather simple. The user is provided with a subject field, a body field, and an send bulk emails button. Once the button is pressed, the bulk emails are sent with the Drupal default email address as the 'sender' and with each users email address hidden by the "To" header. These are current features of this module. Over time, I would like to incorporate a 'choose role" option (e.g admins, moderators, users, everyone) that would send to specified roles. I would also like to see what the community would like to add onto the module in terms of features and would actively add, develop, and maintain the new features/this module. However, I think its important to point out that this module is meant to be simple.

As kiamlaluno asks above "Could not the differences be added to the existing projects?" The thing is, there are no mailing modules out there that do not have Bulk emailing as an additional feature with other modules, require a good amount of Drupal knowledge, and a good amount of setup. The nice thing about this module (and what I believe the community will really appreciate) is that you upload and install it and you are ready to send bulk emails. It is straightforward and simply and, to be honest, a feature I would advocate be incorporated into Drupal core, especially as it is so simple and clean.

To expand on this point, here a some of the modules that attempt to do the same thing as my module:

1. Views Bulk Operations (http://drupal.org/project/views_bulk_operations) in conjunction with Views Send (http://drupal.org/project/views_send)

2. CiviCRM Constant Contact Integration (CiviCRM Constant Contact Integration)

3. OG Mailinglist (http://drupal.org/project/og_mailinglist)

Bulk emailing is secondary in all three of these modules while the Drupal site must have the main modules (e.g. views, og, ect.) working and needed on their Drupal website. Rather than incorporating bulk emailing into these modules, it makes sense to have a simple stand alone module such as the one I am submitting.

The closes module I can find to my module is:

4. Mass Contact (http://drupal.org/project/mass_contact).

In truth, this module is pretty close to my module in theory and scope. It sends bulk/mass emails and can be used to send to different roles ect. Though, it does seem more for the end user while my module is meant specifically for back-end purposes. Additionally, while mass contact works off-off Drupal's inherit contact form, my module simply works off of the drupal hooks and simple php mailing functions and, again, is simple and very easy to use by design.

With all this said, if the reviewers feel that mass contact or the other modules are doing a good enough job, I will completely understand and keep developing in and out of the Drupal framework, and share any other modules I write that I feel will be beneficial to the community with you.

Please let me know if you need any more justification or expansion about me or this module.

Thanks!

Darius

dariusa’s picture

dariusa commented

I see this thread is still listed as needs work, is there anything else I need to do to get for it to be reviewed?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

is there anything else I need to do to get for it to be reviewed?

Yes; you should have changed the status, once you replied to the question. :-)

dariusa’s picture

dariusa commented

Ahh, thanks a bunch for the help kiamlaluno!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

You are welcome.
The fact is that reviewers, noticing the report is marked as needs work, will review another application, which is set to needs review. That is the only reason to change status. :-)

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Needs work
  • The points reported in this review are not in order or importance / relevance.
  • Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
  • Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.
  1. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be formatted. 
  2. 	$result = db_query("SELECT mail FROM users");

    The query is not filtering out the blocked accounts, nor any accounts the user should not access.

  3. The module is not using drupal_mail() as it should. 
  4. // Function for submitting bulk email form
function bulk_mailer_submit($form) 
{
  // ...
} // end function bulk_mailer_submit($form)

    The comment for the submission handler is not the one suggested by the coding standards, and none of the Drupal core functions has a comment at the end of the function.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

I am closing this issue due to lack of replies.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Assigned: avpaderno » Unassigned
Issue summary: View changes

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.