developer-x [developerx]

Allow me to add more detail. Specifically, eventbookings provides the following functionality off of the bookingsap (none of this functionality is currently provided)i:

1. Book resources directly from an Event - aka date enabled Nodes.
2. Allow either multiple or exclusive booking of resources.
3. Add view definitions to allow a user to create views which join an "Event" with a booked resource
4. Provide "out of the box" calendar views of bookable resources
5. Provide ajax functionality that refreshes available resources when date values change on an Event edit page
6. Provide links to conflicting events.
7. Provide security permissions to allow/restrict users from booking resources.

This module works very nicely with publicbookings - syncing event dates and booking records. But doesn't require publicbookings or conflict with publicbookings.

I updated an issue with the maintainer of thge bookingsapi and publicbookings module: http://drupal.org/node/630874

Here is another version - review this one - coder gives it a clean bill of health.

Hi - what is the status of this? I see a link "CVS edit link for developer-x" - but when I click on it, I get an "Access denied" msg. I don't know if that is working as expected or is a bug.

Anyhow, thanks in advance!

No problem - I appreciate everyone who is volunteering - it's great to have a thorough process that ensures quality. I was just confused by the link.

Hi,

I'm unable to reproduce this - can you provide a few details:

1. How does this happen? Did you try to create an Event and it appeared when the add screen was shown?
2. Does it happen on an Edit of an Event?
3. Does it happen when the Event was submitted?
4. Were any resources defined (Bookings API resources)
5. Have you been able to book any resources or is the entire thing broken?

Also, I've attached a new version which fixes a number of bugs - you may want to try installing this.

Hi,

It doesn't require publicbookings - it actually replaces publicbookings. However, you can have both installed. If you modify bookings via eventbookings, the changes will show up in publicbookings and vis-a-versa.

If you can - please run with the latest tar ball - it is more polished and fixes a couple of critical bugs. Also, there is still one change I have pending - I'm going to move the per-content type settings from the eventbookings settings page to content type based settings. So I may provide yet another update fairly soon.

Just in case this wasn't clear, after installing, you will need to goto the eventbookings settings page and enable eventbookings for the date enabled nodes - it won't enable these nodes by default when installing.

Regarding the bug, did this happen as soon as you enabled the module or was there a follow on action? I want to resolve this before making it widely available.

Thanks for testing this!

Ok - you're forcing me to write some proper documentation ;-)

One thing - bookings created by publicbookings will not appear in the resource calendar. What eventbookings does is add in the "missing link" between a booking and a node - so, without that link, the calendar doesn't have any nodes to display.

For the sake of testing - disable publicbookings - that will probably just confuse matters.

Also, I realize that I wasn't handling datestamps properly - I've enclosed another version that handles that field type. I should be handling datetime properly - so I'm wondering if the datetype you were having problems with was really a datestamp?

Here are the step by step instructions:

Installation

• Enable the eventbookings module
• Add a date, datestamp, or datetime field to the proper Content Types
• Goto "Site Configuration > Event bookings"
• Set the bookings status for a booking created by eventbookings
• Don't change the Schedule url template:
• Set the Per Content Type Settings
• If you want to be able to book multiple resources, e.g. a room, a projector, sound equipment, etc..., select Allow mutiple booking of resources
• Select which date, datestamp, or datetime field you want to use for bookings. The field must have to and from values
• The weight determines the position of the table on the form
• Goto "User Management > Permissions"
  • Enable administer bookable Node types for the proper roles
  • Enable book a resource from a bookable Node for the proper roles

Create Bookings API Resources

• Goto "Content Management >Create Content > Bookings API Resource"
• Fill out appropriate fields
• Set the Default Availability to Available
• Click save
• Repeat for the rest of the bookable resources

Modify the Resource Schedule View

• If the date field for the nodes is field_date you don't have to the change the view - it should be ok as-is.
• Else, goto "Site building > Views"
• Locate eventbookings_resource_schedule and click on Edit
• Under Arguments, click on Date: Date (node)
• Under Date field(s):, select the correct date field (use the from field)
• Select Update
• Under Fields, click on Broken/missing handler
• Select Remove
• Select + button in the Fields section
• Select Content in the Groups: dropdown
• Select the same date field as specified in the Arguments
• Click Add
• In the next screen, unselect Group multiple values if it's selected
• Under Label:, select None
• Click Update
• Under Sort Criteria, click on the + button
• Select Content in the Groups: dropdown
• Select the same date field as specified in the Arguments
• Click Add
• In the next screen, select Descending
• Click Update
• Select Broken/missing handler asc
• Select Remove
• Select on the Save button in the lower left to save the changes to the view

Create a booking

• Goto "Content management > Create content > <your_event_type>"
• Add a title
• Change the from and to field in the enabled date fieldset
• As you change the values, the resource bookings table should automatically update reflecting the range and enabling/disabling resource selection based off of availability
• Set the repeat rule if appropriate. This should update the resource booking table
• Select which resources you want to book. If there are conflicts, they will be listed as links - you can click on the link to make changes. Just hit the Refresh Bookings button after making the changes.
• If the bookings were created through Publicbookings, they will not appear as a link. You will need to goto Publicbookings to make any changes.
• Click on the schedule link to see a calendar of the resource's bookings
• Select Save to create the Event

I've enclosed a new tarball with the datestamp fix along with the screenshots showing how things should look if everything is working. Thanks!

The previous screenshot of the calendar has a bug - this one is correct.

I think the reason there isn't any conflicts is because the to and from are the same - thus every booking has a zero duration.

So, if I can fix the "to" problem - I think the other problem goes away.

I'll try to reproduce this - what datatype is your date field and which widget is it set to? Also, what version of the date module do you have?

Found the bug - it had to do with user configurable timezones. I had it set to user configurable, so that is why I wasn't able to recreate it. Anyhow, I fixed it. Also, I made it so you can change the title of the bookings fieldset - you can change it to something like "Fitting Rooms".

Please deploy this and let me know if you start seeing conflicts (you still need to delete the old bookings - just rebook those events to fix them).

Actually, the bug was purely cosmetic - it wasn't actually effecting the bookings dates. The actual reason I suspect that the bookings aren't showing as a conflict is that the setting for the initial booking state is pending. Change the initial state to be finalized in the Event bookings settings page. Then re-save each of the Events - that will change the booking state. The alternative is to use Public bookings to change the state of the booking.

I'm glad everything is working. Regarding managing the bookings - my goal was to not duplicate functionality in publicbookings - but rather complement it - by adding the missing link to the event node. My suggestion is to use both eventbooking and publicbookings together. Create the initial booking via eventbookings. Then manage the workflow with publicbookings. My module "listens" to publicbookings - so if you change anything with publicbookings - my module will do the book keeping to keep the link to the event in sync, as well as any date changes.

The one gap is that my module doesn't create a corresponding event when a booking is created via publicbookings. Maybe I'll look into that.

The other thing I might do is add a link to the publicbookings page from the bookings table that would let you manage the booking.

Anyhow, thanks for doing some QA and enjoy the hiking!

Ok, I've done a 180. The more I looked into your suggestions, the more I thought it made sense for eventbookings to handle the full range of functionality rather than splitting it with publicbookings. To that end, I have another release. The major highlights:

1. You can associate content types to either create availabilities or bookings.
2. You can specify whether pending bookings show as conflicts
3. If you have rights, you can set the status of a booking
4. New views to show availabilities and booked resources for an event.
5. Bug fixes

If you get a chance, install this version and see if it address your requests.

One suggestion, for availabilities, select "multiple bookings" in the configuration screen. Then you can associate an "Regular Business Hours" (or whatever) availability to many resources. This makes it easier to manage availabilities across resources.

This version supports "all day" events. You can define which hours to book for an "all day" event.

BTW, how long does it take to get this reviewed? I understand the nature of the volunteer system - but wanted to have a sense of how long this usually takes. Thanks!

This version is compatible with bookingsapi - 6.x-3.x-dev / 2010-Jul-09

ie javascript fixes

Thank you - I'll review and submit another version with the needed changes

To create a bookable resource (like a meeting, projector, shared van, etc..), do the following:

1. Content Management > Create Content > Bookings API Resource
2. Leave "Parent:" as-is
3. Give it a title, and Default Availability (if it's set to Unavailable, you won't be able to book this resource without defining a specific availability for this resource).
4. Hit Save

Hope that helps

*blush* - good catch, thanks!

Here is an updated version, I made most of the recommended changes. My comments are as follows :

1. The index is defined now as part of the schema and I've removed the call to menu_reguild
2. Removed the t() calls in the schema descriptions.
3. Add call to drupal_load to load the constant definitions
4. Removed call eventbookings_variable_init
5. I've tried to conform to the coding standards - the coder module indicates no problems - but this is my first module, so I might have missed something. If there is something specific - let me know - I appreciated the education :-)
6. Changed the default value to "_undefined_" - but the default value should never be returned - if it hasn't been set, then that leg of code will not driven.
7. I've seen concat of literal strings in various modules similar to mine, and in the documentation for SQL indention, http://drupal.org/node/2497, they concat literal strings. I'll change it, but doesn't seem like I'm violating any standard by doing so.
8. Those variables will always be initialized in the previous call to _eventbookings_parse_date_value - so calling isset seems unecesarry
9. I don't fully understand this comment - could you elaborate?
10. Fixed the lower case reserved words
11. Changed GMT to gmt
12. This value is only accessible by referencing $_POST since it isn't defined within the form structure.
13. $is_availability refers to whether the node defines an event or an "availability" record (that defines a period of availability for a resource)
14. This was taken from the drupal documentation - http://drupal.org/node/331941 - if this is an error, the documentation should be fixed. However, it appears that it isn't needed, so I removed it.

I also made the fixed as mentioned in #33

Thanks.

Webchick,

You do indeed rock! Thanks so much for approving this!

- x