CVS edit link for dgoutam

I am web developer from Kolkata area, India with an experience of more than 15+ years in software development.

Presently I am leading the web2.0 practice for my present employer. I have attended drupalCon SF and an individual member of drupal association.

I found there is no such module for drupal variable management with proper UI.

I have created one and want to contribute.

I am committed to contribute to drupal community which I am very impressed about after visitng the drupalConSF. I am working in drupal part time since 4.5 version and developed various modules for in-house but never contributed back to community and was not visible to me either.

But now I want to give back some of my works to the community.

I have plan to provide few things to develop and contribute to the community in coming future and these are as follow:

- A distro for MircoFinance
- Couple of themes
- Couple of utility modules (variable_management is one of those)

Comments

dgoutam’s picture

Status: Postponed (maintainer needs more info) » Needs review
Issue tags: +Devel, +drupal_variable, +variables
StatusFileSize
new8 KB

I have uploaded my module for review and is attached with this issue.

avpaderno’s picture

Status: Needs review » Needs work
Issue tags: -Devel, -drupal_variable, -variables +Module review

Hello, and thanks for applying for a CVS account.

As per requirements, the proposed module should be more extensively described, and it should compared with the existing solutions (which also means the combinations of modules necessary to create similar features).

dgoutam’s picture

Status: Needs work » Needs review
StatusFileSize
new274.96 KB

Module Name: variable_management

Module Description:
This module is an UI for managing Drupal Variable table from the drupal admin section.

Features:

  • Display all drupal variables in paged fashion
  • Search variables via UI
  • Export all variables or selectively

Dependency;

  • Jquery UI
  • Ctools
avpaderno’s picture

Status: Needs review » Needs work

Devel offers already a variable editor. Why would users not use it, and prefer this module? Did you think of offering your help to add the features you think missing in the Devel editor?

dgoutam’s picture

Status: Needs work » Needs review

Thanks for your time and speedy review.

Yes thats right. But purpose of this module is to provide UI for all the variables and to search and export those variables. Yes I could have thought of this missing features of devel and provide a patch to it but export is not functional part of devel and I am not in favor of putting some dependencies in devel module.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Needs work
  • The points reported in this review are not in order or importance / relevance.
  • Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
  • Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.
  1. License files cannot be committed in drupal.org repository. The license for the projects is the same license used for Drupal, and the relative license file is automatically added to the archive.
  2. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be formatted; how functions, Drupal variables, global variables, and constants defined from the module should be named.
    Check also the character used as new line, which should be the Unix one.
  3.     $sql = "SELECT v.name, v.value FROM {variable} v " . tablesort_sql($header);   
        $count_query = "SELECT count(*) from {variable}";
    

    SQL reserved words should be written in upper case letters; that includes also COUNT.

  4. The function variable_management_overview() is outputting HTML without to use a theme function.
  5.         $data_field_value = (strlen($obj->value) < 50 ) ? $obj->value : substr($obj->value, 0, 50) . " .." ;
    

    There is a Drupal function to truncate a string.
    If a string could contain Unicode characters, then the code should use the Unicode functions defined from Drupal.

  6. function variables_management_get_varaibles_unserilized_value() {
        echo $args;
        die;
    }
    
    • A function should never call die() on Drupal.
    • The code is echo()-ing a variable that has not been passed as argument, nor is it a global variable. If it would be the argument passed to the function, I don't see the need to use a function what simply output its parameter.
    • There is a typo in the name of the function.
avpaderno’s picture

Status: Needs work » Closed (won't fix)

I am closing this issue due to lack of replies.

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: avpaderno » Unassigned
Issue summary: View changes

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.