a_lawry [alawry]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions. In particular, what is the difference between the proposed module and http://drupal.org/project/jeopardy? Why didn't you open a feature report for any features you think missing in the existing project?

Thanks for the reply.
You cannot edit the original post; you can only expand the text in a comment like you did.

You are required to delete all the variables you have used

variable_get('node_questions_wait_period', 0) * 3600 * 24;

Include the CVS keyword $Id$ in each file. This should be in the format

// $Id$ or // $Id$ (Drupal Docs)

Please read coding standards for details.

Also, isn't it possible to modify this module to serve the same purpose?
http://drupal.org/project/block_quiz

There are few bits there and there like missing t() in some l()'s but otherwise it seems fine

• The points reported in this review are not in order or importance / relevance.
• Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
• Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.

1. Menu descriptions and titles, schema descriptions are not passed to t().

2. function node_questions_help($path, $arg) {
     if ($path == 'admin/help#node_questions') {
       $txt = 'The Node Questions module adds questions to nodes that can be answered by the user.';
       return '<p>' . $txt . '</p>';
     }
   }
   

   Strings used in the user interface should be translated.

3. /**
   * Implementation of hook_perm()
   */
   function node_questions_perm() {
     return array('View questions', 'Answer questions');
   }
   
   

   The permissions should be view questions, and answer questions; there should probably be also administer questions, which should be used instead of the generic administer site.

4.   $query = "SELECT ua.* FROM {nq_user_answers} as ua ";
     $query .= " WHERE ua.nid = %d AND ua.uid = %d ";
   
   

   Reserved SQL keywords should be written in upper case.

I'm setting this to closed since there's been 7 weeks without further interest from the applicant.

a_lawry, feel free to re-open it if you are willing to fix the mentioned problems with the module.

Please read the following links as this is very important information about CVS applications.

• Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications.
• Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:
  

  This project is not covered by Drupal’s security advisory policy.