If the "extra" field in a tag is a number (e.g. DRUPAL-5--2-3-1), the separator should be a '.' rather than a '-'. See link which currently has this version tag. The result should be 5.x-2.3.1, but cvs_deploy formats it 5.x-2.3-1. This causes update_status to complain that there is always an update available. Patch attached.

CommentFileSizeAuthor
cvs_deploy-numberextra.patch1.16 KBjhriggs

Comments

dww’s picture

dww
we/he/they
commented
Status: Needs review » Closed (works as designed)

People are misusing the "extra" field. See:
http://drupal.org/handbook/cvs/branches-and-tags/contributions
http://drupal.org/handbook/version-info#contrib

jhriggs’s picture

jhriggs commented

I don't disagree, but regardless, shouldn't this module handle it the same way as core and update_status?

dww’s picture

dww
we/he/they
commented
Status: Closed (works as designed) » Active

#303464: Patch version not properly identified marked duplicate. This is clearly a problem we can't just ignore... I haven't had time to look into it closely and see where things are breaking down, but let's call this active again.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

If link module's version numbers are not correct, then maybe drupal.org's project module setup should be more strict on what it allows to be set in the version field on drupal.org. Or it should not allow freeform input on the version number, but should generate the version number right from the CVS tag, and that should be it. Otherwise complications are inevitable.

dww’s picture

dww
we/he/they
commented

@Gabor: It doesn't allow a free-form version string except for uber site admins to "fix" problems. ;) For the vast bulk of users, the version string is determined from the CVS tag and users can't edit it at all.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Ha, ok, says an uber site admin :) Then what is allowed there should be supported in CVS deploy I guess, and if it always has a direct correlation to the CVS ID, then there should be no opportunity for errors, which an uber site admin might need to fix, so we should not have the freedom to edit that :)

dww’s picture

dww
we/he/they
commented

The ability is there for converting the old HEAD releases as per the instructions at http://drupal.org/node/274027.
I suppose I could put in extra validation in case people with this power can't be trusted not to break things, but that seemed like bloat for d.o. ;)

dww’s picture

dww
we/he/they
commented
Status: Active » Closed (won't fix)

cvs_deploy is dead. Long live git_deploy.