Closed (fixed)
Project:
Customerror
Version:
7.x-1.1
Component:
Documentation
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
13 Aug 2013 at 01:42 UTC
Updated:
21 May 2014 at 13:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
alexkb commentedComment #2
gisleThank you for taking the time to report this and creating a patch.
You're right about the present example in the README.txt using the
l()-function to provide a login link for 403 pages was wrong, and also that a correct options array for this function isarray('query' => drupal_get_destination()).However, the way the module is written, the destination url in the options array is never used. Instead, the module keeps track of the URL requested, and will always redirect to that. You can put anything (right or wrong) in the options array, and it will be discarded. In light of that, I've changed that line in the example to:
without supplying an options array. Note that the redirect to the originally requested URL will still work.
Also thank you for adding a section about templating options to the FAQ. I've used that partion of your patch.
The changes resulting from this issue is in the latest development snapshot (7.x-1.x-dev, dated 2013-Aug-15). Please review.
In addition to updating the README.txt, I've put the module documentation online in the Community Documentation area. This is a wiki, and anyone can edit. This, I hope, will make it faster and simpler to get module documentation corrected and updated.
To anyone reading this: Feel free to improve on the CustomError module documentation.
Comment #4
gisleFixed in release 7.x-1.1.