Needs work
Project:
Customerror
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Feb 2012 at 21:58 UTC
Updated:
24 May 2023 at 09:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pbuyle commentedComment #2
samw commentedThanks - this patch was just what I was looking for and applied fine.
Out of coincidence, after applying this did you get any errors from the Variable module? I was getting an "Undefined index: module in variable_type_include() (line 428 of variable.module)" warning, which I suppressed with an if statement around that line? Not sure why I was getting that but it seemed to sort it out.
Would love to see this patch committed as it fits the bill perfectly!
Comment #3
gisleThis is a duplicate of: http://drupal.org/node/1852620
Need to compare these to determine which patch provides the best solution.
Comment #4
gisleApplied patch to commit 9ad93b4 on 7.x-1.x branch:
Just installing the patch produces a fatal error:
Adding variables to the configuration produces the following warning:
This means that the patch needs work.
It is not clear to me why this module needs support for variable translations.The suggested patch adds dependency on another module, and this must be avoided for users not interested in having support for variable translations.I'll leave this open as a placeholder, but this is not high priority for me.
Comment #5
gisleI am not going to work on this patch. Feel free to sign on if you're interested in working on it.
Working on this patch entails removing the Variables module dependency for users that does not want this dunctionality, making sure it applies cleanly to the latest dev snapshot, and providing documentation about how to make use of it.
Comment #5.0
pbuyle commentedUpdate description according to #4 and #5.
Comment #6
gisleAlso requested for the Drupal 6 version: http://drupal.org/node/1379098
Comment #6.0
gisleFix bad copy/paste
Comment #6.1
gisleInserted missing word.
Comment #7
_tarik_ commentedDoes it make sense to provide changes for a version compatible with Drupal 7 if it has an end life in November 2023?
Comment #8
gisleWhile the announced EOL of Drupal 7 is November 2013, it may be extended further. A lot of the current owners of websites built with Drupal is not capable of upgrading to Symfony-based Drupal. I doubt the DA wants to alienate such a huge user base.
So a good patch or MR for this will be committed.