Closed (won't fix)
Project:
Customer Profile Type UI
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
10 Nov 2016 at 18:14 UTC
Updated:
20 Feb 2017 at 13:22 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
renatog commentedIn attached is the patch with the fix.
Comment #3
cebasqueira commentedWorks look good!
Comment #4
cebasqueira commentedComment #5
larruda commentedMaintainers was notified by email.
Comment #6
acrazyanimal commentedNo. It is not "good". Really it is the commerce_rma module that should be fixed. It is providing insufficient info when defining its profile type. I don't believe in fixing an issue by simply ignoring the real problem.
First of all commerce_rma in its commerce_return sub-module, which is what I'm assuming is actually the source of this issue, should be using
hook_commerce_customer_profile_type_info()instead of the alter hook for providing info about a new customer profile type. This way it wouldn't have missed adding in the'module'parameter. Secondly if it needs to use the alter hook, which it doesn't, it SHOULD be ensuring it adds all of the default parameters that are expected by commerce as you can easily find incommerce_customer_profile_types()and which the code you fixed in this module clearly calls.If you absolutely cannot get this fixed in the commerce_rma module then I will give in and commit this, but shouldn't have to, don't want to, and am frankly annoyed by such an issue.
Comment #7
larruda commentedSo it needs some work...
Comment #8
acrazyanimal commented@larruda I was going to put it as "closed - won't fix" but I can wait to see if you get it fixed in the commerce_rma first. There is no work to be done for this module or issue patch. The patch is fine the way it is, but it is unnecessary because by definition the profile type info should have the 'module' parameter. The fact that you are running into this issue is because the commerce_return sub-module does not populate that required default parameter.
Comment #9
cesarromagnolo commentedThis bug occurs in commerce_rma (stable version) not in customer_profile_type_ui, but in dev-version of commerce_rma this bug was fixed.
Comment #10
cesarromagnolo commentedI Use Customer Profile Type UI (7.x-1.0) and Commerce RMA (7.x-2.0-rc2+25-dev)
Comment #11
larruda commented@acrazyanimal I guess you can close this as won't fix then, as you planned. I'm not sure if it counts credit towards issues closed with that status, but just in case please give the proper credit to the guys here that spent their time to look at the issue. Thanks a have a great week!
Comment #12
acrazyanimal commentedGood God .. unbelievable! You'll get credit if a patch you create for a module is committed. Now that I think of it, you should add me to the 'Credit others' input when you create the patch for the commerce_rma module. After all I did point you guys in the right direction. Yes, I believe you MUST do this! If you don't you'll just be lying to yourselves. lol I'll be watching for my notification. ;)
Comment #13
botrisI've created a patch at #2670128: Notice: Undefined index... which should solve the problem in the module itself.
Also raised an issue to move the profile creation to
hook_commerce_customer_profile_type_infoat #2854171: Commerce profiles should use hook_commerce_customer_profile_type_info