Hi,

When doing a coder review of the custom pagers module, I found that the new Drupal 6 Schema API is not being used in the update functions in the install file for adding new columns to the database. The attached patch addresses this issue.

Cheers,
Stella

CommentFileSizeAuthor
custom_pagers_schema_api.patch2.51 KBstella

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

These changes look good to me. Checked it applied cleanly etc. but I didn't actually run the update path. Should be good to go though.

eaton’s picture

eaton commented

Schema API should not be used for *older* update functions that predate schema API, should they?

I'm not sure about this one, it's worth thinking about.

eaton’s picture

eaton commented
Status: Reviewed & tested by the community » Fixed

Looks like this is indeed the right way. Checked in. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.