This is a test

CommentFileSizeAuthor
#1 added_more_link-1211438-1.patch1.77 KBrtdean93

Comments

rtdean93’s picture

Title: Testing the patch » Read More patch
Status: Active » Needs review
StatusFileSize
new1.77 KB
xorcus’s picture

the patch implements the required feature correctly and passes all the tests,
but still needs work for the following two reasons:

- apply patch reports two whitespace warnings:

/Users/miroslav/Downloads/added_more_link-1211438-1.patch:23: trailing whitespace.
  ); 
/Users/miroslav/Downloads/added_more_link-1211438-1.patch:38: trailing whitespace.
    'type' => MENU_CALLBACK, 
Checking patch current_content.module...
Applied patch current_content.module cleanly.
warning: 2 lines add whitespace errors.

- it includes extra (garbage) code which does not do anything at the end of _current_content_page() function:

  //Add a link to the page for more entries.
  $block['content']['more'] = array(
    '#theme' => 'more_link__current_posts',
    '#url' => 'current_posts',
    '#title' => t('See the full list of current posts.'),
  );
xorcus’s picture

Status: Needs review » Needs work