Problem/Motivation

Scanning ctools with Upgrade Status produces the following warnings:

ctools/src/Form/ManageResolverRelationships.php line 137: Method Drupal\ctools\Form\ManageResolverRelationships::getContextClass() invoked with 0 parameters, 1 required.

ctools/src/Plugin/Relationship/TypedDataRelationship.php line 86: Method Drupal\ctools\Plugin\Relationship\TypedDataRelationship::getMainPropertyName() invoked with 0 parameters, 1 required.

Steps to reproduce

scan the module with Upgrade Status.

Proposed resolution

use the appropriate number of parameters.

Remaining tasks

make an MR. I am assigning this to myself because I plan to address it right away.

Issue fork ctools-3608777

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings opened merge request !94

benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
Status: Active » Needs review

The phpunit failures are not caused by this commit; they're pre-existing environmental issues unrelated to this branch:

21 of the 22 errors (ctools_block, ctools_entity_mask, and the Relationship kernel tests) trace back to a Drupal core compatibility gap: on Drupal core 11.3+, the "body" field storage for node and block_content entities was split out of core into new deprecated, hidden submodules (node_storage_body_field, block_content_storage_body_field — see drupal.org change record 3223395). node_add_body_field() no longer creates that field storage itself; it now assumes it already exists.

CToolsWizardTest::testEntityWizard exercises the generic config-entity CRUD wizard (ctools_wizard_test forms), which has no connection to the Relationship/context classes changed in bafaf647.