Problem/Motivation

Checking "Disable filters" for a block display of a view does not add the corresponding options to the "Configure block" dialogue in "Block layout".

Steps to reproduce

  1. Install and enable Chaos Tools and Chaos Tools Views.
  2. Create or edit a block display for a view with fields, filters and sort criteria.
  3. Click the linked text next to "Allow settings" (probably "Items per page").
  4. Check all checkboxes (probably "Items per page", "Pager offset", "Pager type", "Hide fields", "Reorder fields", "Disable filters", "Configure sorts"), and save the view.
  5. Place the block via the block layout.
  6. Note that there are options to set the "Items per block" (page), "Pager offset" and "Pager" (type); to "Hide fields" and "Reorder fields"; and to "Configure sorts" (i.e. sort order) - but not to "Disable filters".
  7. Note also that there are no corresponding errors in the Recent log messages.
CommentFileSizeAuthor
#4 Screenshot 2020-10-28 at 16.11.57.png190.1 KBdarrenwh
#3 ctools-Disable_filters_only_applies_to_exposed_filters-3165367-3.patch1.85 KBpaulocs

Comments

RobbM created an issue. See original summary.

robbm’s picture

robbm commented
Title: "Disable filters" checkbox has no effect » "Disable filters" only applies to exposed filters

Actually, it does allow exposed filters to be disabled. And maybe that's all it's intended to do. If so, that might call for the labels to be clarified (e.g. "Disable exposed filters").

Title updated for clarity.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Active » Needs review
StatusFileSize
new ctools-Disable_filters_only_applies_to_exposed_filters-3165367-3.patch1.85 KB

As @RobbM said, "Disable filters" only works with exposed filters and it is intended to do so.

It is good point to change the label. I provided a patch for it.

Thanks!

darrenwh’s picture

darrenwh commented
StatusFileSize
new Screenshot 2020-10-28 at 16.11.57.png190.1 KB

Just trying to replicate this based on the instructions.

Using a clean build of Drupal 8.9.7, created a basic view with an exposed sort on order, have checked all of the boxes and applied the patch but can't see the disable filter option?

darrenwh’s picture

darrenwh commented
Status: Needs review » Needs work