Page title check plained twice, seems the mistake here:

First example:

in /sites/all/modules/contrib/ctools/page_manager/plugins/tasks/page.inc

$subtask = array(
    'name' => $page->name,
    'admin title' => check_plain($page->admin_title),
    'admin description' => filter_xss_admin($page->admin_description),
    'admin summary' => 'page_manager_page_admin_summary',

Title sets with check_plain.

in /sites/all/modules/contrib/ctools/page_manager/page_manager.admin.inc

/**
 * Render the edit page for a a page, custom or system.
 */
function page_manager_edit_page($page) {
  drupal_set_title($page->subtask['admin title']);
  // Provide and process the save page form before anything else.
  $form_state = array('page' => &$page);

Here used function drupal_set_title without "PASS_THROUGH" flag, so check plained in second time.

Second example:
drupal_set_title(t('Create @name', array('@name' => $types[$type]->name)));
I think it is mistake here.

Same mistakes in other places.

So therefore we see not correct page title.

Comments

samvel’s picture

Status: Active » Needs review
StatusFileSize
new3.69 KB

I did patch

* but i not sure about one place:

if (isset($plugin['page title'])) {
    drupal_set_title($plugin['page title']);
}

in /sites/all/modules/contrib/ctools/includes/page-wizard.inc

samvel’s picture

Issue summary: View changes

Refactoring description

samvel’s picture

up!

samvel’s picture

Issue summary: View changes

Refactoring issue description

dsnopek’s picture

Issue summary: View changes
Issue tags: +panopoly

Marking this patch as used in Panopoly.

dsnopek’s picture

Status: Needs review » Reviewed & tested by the community

Marking as RTBC since we've been using this for a while!

  • japerry committed c2e6e10 on 7.x-1.x authored by Samvel
    Issue #1978378 by Samvel, dsnopek: Page title check plained twice
    
japerry’s picture

Fixed! thanks for the patch and the review!

japerry’s picture

Status: Reviewed & tested by the community » Fixed
dsnopek’s picture

Woohoo! Thanks. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

samvel’s picture

Thanks