This is currently a placeholder page. This needs to be removed:

  // @todo --fix.
  variable_set('page_manager_term_view_disabled', TRUE);
  drupal_set_message(t('Due to changes in taxonomy, the taxonomy integration with Page Manager is currently not implemented.', array('%callback' => $items['taxonomy/term/%taxonomy_term']['page callback'])), 'error');
  return;

Taxonomy has been changed a lot and this is going to seriously take some effort to update.

CommentFileSizeAuthor
#11 1016510_1.patch6.33 KBeclipsegc
#2 1016510.patch7.07 KBeclipsegc

Comments

wikp’s picture

subscribe

eclipsegc’s picture

Assigned: Unassigned » eclipsegc
Category: bug » task
Status: Active » Needs work
StatusFileSize
new7.07 KB

Ok, this is a pretty good start I think. We still need to figure out how to handle multiple terms, but I'm thinking that particular issue might need to move upstream to take advantage of entity_load() since it can now load multiple entities at once.

eclipsegc’s picture

Status: Needs work » Needs review

oops

redben’s picture

Subscribing
(after almost 5 years of drupal i still don't know how to apply a patch...shame on me ! heading to http://drupal.org/patch/apply )

willmoy’s picture

Sub, will try to test this w/e

willmoy’s picture

Status: Needs review » Needs work

Hmm... so... interesting... using panels it enables and it overrides, which is great. Not sure what the split in the following is between ctools/panels.

I now have two 'view' links in my tabs, each going to taxonomy/term/nn.

This pops up on enable:
* Notice: Object of class stdClass could not be converted to int in _menu_router_build() (line 3466 of /var/aegir/platforms/ff-1.4/includes/menu.inc).
* Notice: Object of class stdClass could not be converted to int in _menu_router_build() (line 3466 of /var/aegir/platforms/ff-1.4/includes/menu.inc).

Some of the options in the add context drop down come up twice. They go to different places (for the tax term, one loads a form with and one without a vocabulary field).

<select class="ctools-context-add-url form-select" id="edit-buttons-context-item" name="buttons[context][item]">
<option value="entity:file">File</option>
<option value="entity:media">Media</option>
<option value="node">Node</option>
<option value="entity:node">Node</option>
<option value="node_add_form">Node add form</option>
<option value="node_edit_form">Node edit form</option>
<option value="term">Taxonomy term</option>
<option value="entity:taxonomy_term">Taxonomy term</option>
<option value="entity:taxonomy_vocabulary">Taxonomy vocabulary</option>
<option value="vocabulary">Taxonomy vocabulary</option>
<option value="token">Token</option>
<option value="user">User</option>
<option value="entity:user">User</option>
<option value="view">View</option>
</select>

The cancel button doesn't work in the add context form, although the cross does (FF 3.6).

I can't get the context to do anything useful so can't tell if the content pulls through or not.

Hth and thanks.

Alexander Matveev’s picture

subscribing

Anonymous’s picture

subscribing

eclipsegc’s picture

@willmoy

The form element you've pasted here is actually a side effect of the fact that we have nid, term, uid etc arguments, as well as a single entity_id argument that can replace all of those. Applying this patch: http://drupal.org/node/1033222 SHOULD remove the older arguments from the user interface (pushing you to use the new entity_id argument. This has the benefit of not harming existing page definitions that use the older arguments. Current discussion about updating from 6.x to 7.x has led to this conclusion for the moment.

Hopefully that helps some for people wanting to test this patch.

spencer.nowak’s picture

subscribing

eclipsegc’s picture

Status: Needs work » Needs review
StatusFileSize
new6.33 KB

This should remove the extra view tab. If you apply this patch and still have issues with that, clear cache.

eclipsegc’s picture

Anonymous’s picture

+

merlinofchaos’s picture

Status: Needs review » Fixed

Merged the branch in.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.