Closed (fixed)
Project:
CSSTidy
Version:
6.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Jun 2010 at 15:17 UTC
Updated:
8 Sep 2010 at 08:47 UTC
After installing and enabling the CSSTidy module, my CSS files do not seem to get Gzipped anymore by CSS Gzip module. YSlow is complaining that I should Gzip these files (and before it was not). Furthermore, in the "Components" view of YSlow I can see that the file size of the CSS files itself got lower (due to CSStidy probably) but that there is not Gzip filesize anymore.
Comments
Comment #1
philbar commentedI have GZip working fine on my install. Let me look into #829216: "Division by zero" error and see if that fixes your problem.
Comment #2
philbar commentedNope, this is not going to be related to the previous issue.
Comment #3
philbar commentedDid you enable CSS Gzip after CSSTidy?
Comment #4
jaochoo commentedNo, I installed and enabled CSS GZip first and found CSSTidy later on.
Comment #5
graytoby commentedI'm having the same issue. I have 2 css files after aggregation, first one is generated by Data URI Sprites module, and this one gets compressed. Second gets processed by CSSTidy, but skips Boost compression. Perhaps module weight issue?
Comment #6
philbar commentedSee if this fixed it: http://drupal.org/cvs?commit=403084
It should be in the dev tonight.
This issue might not be happening to me because I have CSS Embedded Images enabled which has the same code.
Comment #7
philbar commentedComment #8
graytoby commentedNope, after installing dev version, css images won't load. I'm going to try css embedded images modules and see if that makes a difference.
Edit: No luck with embedded image. No compression at all, I tried both, stable and dev version.
Comment #9
philbar commentedDid you get the dev for "2010-Aug-06"?
This is the fix I added: http://drupal.org/cvs?commit=403084
Is it in yours?
Comment #10
philbar commentedThe fix is for CSS Gzip. Perhaps we need one for Boost as well.
Comment #11
philbar commentedCan you try the following?
In
csstidy.module, after the following code (it's near the top of the file):add:
I'm sorry I can't be more helpful, but since I can't reproduce the issue, I'm having to rely on you.
Comment #12
philbar commentedBoost Issue: #875964: Compatibility Issue: Processing Gzip CSS Last
Comment #13
graytoby commentedI added the code to the dev version. With data uri sprites module, css images won't show, request for that css file returns 404, so I can't tell if it's compressed or not. With css embedded images still no compression.
Comment #14
philbar commentedI would recommend using CSS Embedded Images over Data URI Sprites. They are likely going to merge soon.
Perhaps you should use CSS Gzip until we get this issue sorted out.
Comment #15
graytoby commentedCss embedded images+css gzip didn't work. The end result is lack of css file. Looks like the best configuration for me at the moment is boost+parallel+data uri sprites.
Comment #16
philbar commentedA comparison of
hook_theme_registry_alter(). CSSTidy and CSS Embeded Image have identical code here. It looks like Parallel and Data URI Sprites also have the same code but is missing the part which moves CSS GZIP's preprocess after our module's preprocess. It's still not clear what could be the issue here.CSSTidy
Parallel
Data URI Sprites
Comment #17
philbar commentedReplacing our code with Parallel's code. They are nearly identical, so not sure if it's fixed.
Unless this bit is causing this problem (which has been removed):
http://drupal.org/cvs?commit=411256
Comment #19
jaochoo commentedI am using CSS embedded images + CSS GZIP + Parallel and it works. It's just CSSTidy which seems to blow up everything. ,-)
Comment #20
philbar commentedAre you using the latest dev of CSSTidy?
I didn't add the fix to version 1.3.
Comment #21
jaochoo commentedNo, sorry, we already launched and so we did not use CSSTidy anymore. Maybe I'll try the latest version on a test machine later on.