Problem/Motivation

https://www.drupal.org/node/3395575

Reporting Handler plugins should use PHP attributes instead of PHPDoc annotations

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork csp-3619410

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gapple created an issue. See original summary.

ptmkenny made their first commit to this issue’s fork.

ptmkenny opened merge request !66

ptmkenny’s picture

ptmkenny commented

I added an MR that adds support for attributes (but does not drop support for annotations). Based on the issue title, it seems you may want to switch from annotations to attributes in one pass; I can rework the MR if that's what you want to do, but many modules are doing a two-phase transition where attribute support is added and then (Drupal 13?) annotation support is dropped.

ptmkenny’s picture

ptmkenny commented
Status: Active » Needs review
gapple’s picture

gapple
he/they
Primary language English
commented

CSP 2.2 already requires ^10.2 || ^11, so from the change record it should be fine to completely switch in one release, but there's no problem keeping the annotations in place to be safe.

(CSP 2.3 will also require ^11 || ^12)