Hi guys,

Just a few quick improvements that could probably be very easily added to the module:

1 - CSNA Configuration page menu position:
Currently, by default, the module's configuration page is directly under the Configuration menu link in the administrator's menu (management menu).
See in csna.module, line 32:

<?php
  $items['admin/config/csna'] = array(
[...]
?>

Since this module is related with third party authentication services, a little bit like OAuth or GMap modules, I would believe it would be more appropriate to move CSNA's configuration page under the Web services menu item.


The navigation would then be:
Configuration > Web services > Chinese Social Networks Authentication settings (CSNA)
Which would correspond to the following menu path:

<?php
  $items['admin/config/services/csna'] = array(
[...]
?>

Ideally, we would able to change the title and description of the menu item as well.


2 - CSNA Configure links on admin module page:
Since we would be moving the module admin page and changing its path, it would probably be a good time to have all modules/sub-modules admin configure links updated in all .info files(For example: csna.info or csna_kaixin.info).
We would only need to add the following line to all .info files in the module: configure = admin/config/services/csna


I think these very small changes could slightly improve module's usability and get closer to Drupal's recommended best practices.


Please let me know if you would have any objections, questions, comments or issues on these requests, I would surely be glad to explain in more details.


Thanks very much for your feedback in advance.
Cheers!

Comments

dydave’s picture

Quick follow up on this ticket.

Please find attached to this comment a patch against the latest 7.x-1.x version at 02379e0 which should fulfill the previous requests in this ticket summary (points 1 and 2): csna-menu-configure-links-1908242-1.patch

Detailed log:

  1. Modified CSNA settings form page menu link path to be under Web services: admin/config/services/csna
    Modified menu title and description to be more explicit.
  2. Modified all .info files (total 5) to add configure link to the updated path (from point 1).

Patch has been tested and seems to work as expected (after flushing cache if applied on a running site).

Please let me know if you would have any questions, objections, comments, suggestions, recommendations or concerns on the patch or any of the requests above, I would be glad to explain in more details or re-roll the patch if necessary.

I would greatly appreciate if you could take a look at the attached patch and potentially consider committing it to module's repository, it would certainly help improving overall module's usability and quality.

Thanks in advance for your feedback and testing.
Cheers!

alfababy’s picture

Status: Active » Reviewed & tested by the community

Thanks DYdave,

I checked your patch, looks good idea for adding configure link and moving the configure path.

I will push your patch later.

alfababy’s picture

Status: Reviewed & tested by the community » Closed (fixed)

Thanks DYdave again,

The patch has pushed.

Status: Needs review » Closed (fixed)