Problem/Motivation

As per the TODOs in README.md:

Show calculated start and end date on renew form. This would make it more clear what the renewal period will be, before committing to it.

Issue fork crm_membership-3576822

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

svendecabooter created an issue. See original summary.

nickolaj made their first commit to this issue’s fork.

nickolaj opened merge request !3

nickolaj’s picture

nickolaj
Primary language Ukrainian
commented
Status: Active » Needs review

Added `calculateRenewalPeriod()` method to `MembershipTermInterface` with implementations in FixedDuration and RollingDuration plugins. The renew form now displays the calculated start and end dates before submitting. Also refactored `renew()` methods to reuse the new calculation method, and removed the corresponding TODO from README.md.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the MR.
Tested this, and it seems to work as intended.

Maybe the label "Calculated renewal period" needs better wording, but I'm not a native English speaker and don't know what would be most appropriate here.