When enabled Deferred CSS Execution: Use JS to load CSS option in AdvAgg module - then no css loaded, because critical css did change code for include css file and regular expression from advagg can't do it staff (load js with loadCSS library)

Issue fork critical_css-3315557

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cosolom created an issue. See original summary.

cosolom opened merge request !1

cosolom’s picture

cosolom commented
Status: Active » Needs review
albertosilva’s picture

albertosilva
Primary language Basque
Location Basque Country
commented
Assigned: Unassigned » albertosilva
Status: Needs review » Active

Hi @cosolom,

Critical CSS module has an option to enable/disable its execution. I was wondering if it is not easier to disable Critical CSS if you find that it is incompatible with AdvAgg in some way.

Or maybe is it incompatible only in some URLs which have "Deferred CSS Execution: Use JS to load CSS" option enabled? If that is the case, I find your proposal and merge request adequate. Please let me know if that is the case you are experiencing.

Thanks

cosolom’s picture

cosolom commented
Status: Active » Closed (works as designed)

I think it's more easy to disable AdvAgg defer for css and use the same functionality from Critical CSS module