I see various notices in different places, let's correct them :-)

CommentFileSizeAuthor
#2 0001-fixing-some-notices.patch9.01 KBmarvil07
#1 0001-fixing-some-notices.patch2.12 KBmarvil07

Comments

marvil07’s picture

marvil07 commented
Status: Active » Needs work
StatusFileSize
new 0001-fixing-some-notices.patch2.12 KB

on admin/settings/creativecommons:

changed in this patch:

    * Notice: Undefined property: creativecommons_license::$error in creativecommons_license->is_valid() (line 316 of sites/all/modules/creativecommons/creativecommons.class.php).
    * Notice: Undefined variable: filename in creativecommons_license->get_image() (line 244 of sites/all/modules/creativecommons/creativecommons.class.php).
    * Notice: Undefined variable: px in creativecommons_license->get_image() (line 259 of sites/all/modules/creativecommons/creativecommons.class.php).

pending:

    * Notice: Undefined property: stdClass::$creativecommons in creativecommons_user() (line 2165 of sites/all/modules/creativecommons/creativecommons.module).
    * Notice: Undefined property: stdClass::$creativecommons in creativecommons_user() (line 2166 of sites/all/modules/creativecommons/creativecommons.module).
    * Notice: Undefined property: stdClass::$creativecommons in creativecommons_user() (line 2167 of sites/all/modules/creativecommons/creativecommons.module).
marvil07’s picture

marvil07 commented
Title: avoid notices » avoid notices and warnings
Status: Needs work » Needs review
StatusFileSize
new 0001-fixing-some-notices.patch9.01 KB

updated

kreynen’s picture

kreynen commented

The patch in #2 can be applied without errors, but it's hard to tell if it solves a problem I can't replicate.

kreynen’s picture

kreynen commented
Status: Needs review » Fixed

Since this simply checked to see that a few variables were set before trying to display them, I went ahead and committed marvil07's patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.