Closed (fixed)
Project:
Crazy Egg Integration
Version:
7.x-1.2
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
11 Jun 2020 at 17:39 UTC
Updated:
5 Aug 2020 at 19:54 UTC
Jump to comment: Most recent
There are two functions, is_page_allowed() and is_role_allowed() that could possibly conflict with similarly named functions in other modules (or themes). It is a best practice to namespace all functions in a module with the name of the module to avoid any potential conflicts.
The function is_page_allowed() could be renamed crazyegg_is_page_allowed() or even _crazyegg_is_page_allowed(). Some maintainers like to name their internal functions with an underscore, to signal to other maintainers that these functions should not be called directly from outside this module.
Comments
Comment #2
crazyegg commented