The picture-text should be translateable so that internationalization is not a problem.

Comments

kirie’s picture

Assigned: Unassigned » kirie

Absolutely - thanks

kirie’s picture

Actually - according to the Drupal docs "custom data from user input or other non-code sources should not be passed through t()" (see http://api.drupal.org/api/function/t). Do you have an idea how I could handle it? One way you could work around this is to override the corner.tpl.php file and output your custom HTML with the image title wrapped in a t().

lomz’s picture

I am no programmer, but http://drupal.org/project/comment_count_image has a translateable image.

druvision’s picture

The following two requirements will cover it:

  1. Support the 'language' attribute on the 'add corner' / 'edit corner' page - so that it will be possible to define that the corner will be displayed only for specific languages (You may find a similar GUI in the I18n_block module of the i18n package - but it should work even if we have one language and the i18n block is not installed).
  2. Support user-defined text (I am not a GD expert, but I think that rendering diagonal text may be done with some image functions of the PHP GD library).
kirie’s picture

I think I prefer option one there - using GD to overlay text on images usually doesn't produce a satisfactory result, and there are a bunch of other considerations with that approach too (different positioning of the text for different languages etc). Thanks for the reference to the i18n_block module - I'll have a look at that one and see what I can come up with. I'll start working on this as soon as I've gotten the 6.x.1.0 release out the door (soon I hope).

kirie’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Active » Closed (fixed)