Problem/Motivation

Sorry I lack permissions to grant this. The other maintainer has them, you can reach him directly in the contact form. Meanwhile, I will review your contributions!
I am offering to maintain the "Convert Bundles" module. I want to help maintain and develop this module. Issues I worked on in this module:
#3566158: Clean up the code
#3566142: Avoid calling getAllBundleInfo() inside a loop
#3566148: Replace direct SQL query on config table with Config Storage API
#3566143: Replace incorrect {@inheritdoc} docblocks with short method descriptions.
#3566144: Improve naming/typing: $currentUser stores an ID, not a user object
#3566154: Use $form_state->getValue() instead of indexing $form_state->getValues()
#3566155: Add composer.json file

Thanks!

Comments

andrii momotov created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Hi @andrii momotov

I am the co-maintainer of this project, while I do not have the permissions to make you a maintainer, I am willing to review and merge your issues. I'll review them now and we can co-ordinate together on preparing a release.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#3566158: Clean up the code, +#3566142: Avoid calling getAllBundleInfo() inside a loop, +#3566148: Replace direct SQL query on config table with Config Storage API, +#3566143: Replace incorrect {@inheritdoc} docblocks with short method descriptions., +#3566144: Improve naming/typing: $currentUser stores an ID, not a user object, +#3566154: Use $form_state->getValue() instead of indexing $form_state->getValues(), +#3566155: Add composer.json file
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: Offering to maintain Convert Bundles » Review contribution epic - Convert Bundles
Issue summary: View changes
el1_1el’s picture

el1_1el commented
Status: Needs review » Fixed

Everyone should be all set

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

andrii momotov’s picture

andrii momotov commented

Hi Joseph, thanks, sounds good. Let me know if you need anything from my side.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: Unassigned » joseph.olstad
Status: Fixed » Active

Reviewing all of these issues now.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » Unassigned
Status: Active » Fixed

https://www.drupal.org/project/convert_bundles/releases/3.0.0-beta1
https://www.drupal.org/project/convert_bundles/releases/2.0.0-beta5

Dropped support of 2.0.x, but tagged a last beta for it just before.

I suggest everyone should upgrade to 3.0.x now and this will simplify our support base. This module already being extremely risky to use and support.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@andrii momotov,

Thanks for your contributions.

Have a look at the source markup for my releases

You'll notice that I keep a chronological explanation in each release. So the notes for 3.0.0-alpha1 are included in the 3.0.0-beta1 release

Also you'll notice this structure:

Open square bracket, hash-symbol , issue number and close square bracket.

A lot of people don't understand that d.o automatically hyperlinks these when issues, issue comments or releases are published.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.