Problem/Motivation

Files: src/Form/ConvertBundlesForm.php and src/Controller/EntityController.php

The form stores $this->currentUser = $current_user->id();. The property name implies it contains a user/account object, but it stores an integer/string ID. This reduces readability.

Proposed resolution

Rename the property to $currentUserId

Issue fork convert_bundles-3566144

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andrii momotov created an issue. See original summary.

andrii momotov’s picture

andrii momotov commented
Assigned: Unassigned » andrii momotov

I assigned the task myself because I plan to fix this issue and make a Merge Request.
Please do not work on this issue.

andrii momotov opened merge request !31

andrii momotov’s picture

andrii momotov commented
Assigned: andrii momotov » Unassigned
Status: Active » Needs review

Created MR. Please review. Thanks.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: Unassigned » joseph.olstad
Status: Needs review » Active

Reviewing

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » Unassigned
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.