Problem/Motivation

Given that the module automatically adds an action regardless of the content type.

There are certain modules which have a non-standard implementation which doesn't require the entity to be passed into the action.

An example module is the drd module

Steps to reproduce

Install the DRD module

Clear the cache and attempt to view the available actions.

Proposed resolution

Add a neutral access response if the entity could not be resolved.

Remaining tasks

N/A

CommentFileSizeAuthor
#3 3282283-convert_bundles-error-handling-3.diff2.97 KBcodebymikey

Issue fork convert_bundles-3282283

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

codebymikey created an issue. See original summary.

codebymikey opened merge request !5

codebymikey’s picture

codebymikey commented
Status: Active » Needs review
StatusFileSize
new 3282283-convert_bundles-error-handling-3.diff2.97 KB
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

seems a bit risky this change just basically returning true if the access $object is null or empty.

I imagine something should be logged or an error message should go in at least to the addMessage
or watchdog

almost better off it crashes? not sure

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Postponed (maintainer needs more info)