Remove destination parameter from delete link [#932518]

Hello again,

the delete link of links is /node/X/delete?destination=node/X

Doesn't make sense that a delete link gets a destination parameter.

The destination doesn't exist after the delete.

Clear?

Thanks

Yannick

Comment	File	Size	Author
#6	contextual-932518-6.patch	639 bytes	vijaycs85
#2	contextual_node-delete-destination_932518.patch	559 bytes	teezee

Comments

Comment #1

teezee commented 7 October 2010 at 14:56

Makes sense...

I'll try to find the correct statement to skip the destination.

1. Delete link must still have a destination set when you would click the node-delete link from an overview page with node teasers, but:
2. Delete link shouldn't have a destination set to node/$nid where $nid is the same as the node about to be deleted.

Comment #2

teezee commented 7 October 2010 at 16:45

Status:

Active

» Needs review

Status	File	Size
new	contextual_node-delete-destination_932518.patch	559 bytes

Patch removes the 'query' part of the link array by default. It adds the 'query' part of the link conditionally.
Do NOT add a destination that points to the node when:

$_GET['q'] points to node/$nid (where $nid is it's own node ID)
$node->body is set

In teaser mode the $node->body is not set, but in full page mode it is. Also, when using revisioning (and viewing node/$nid/revisions/$rev/view) or panel pages for your node view, the $_GET['q'] might not be node/$nid, but it likely is a page where the full node is displayed, and that's where you don't want to end-up after deleting IMHO.

Please test!