Closed (fixed)
Project:
Context OG
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
8 Jan 2011 at 05:08 UTC
Updated:
5 Dec 2011 at 22:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
marcp commentedI agree -- that would be great. The module is quite small, so it shouldn't be difficult.
Anyone want to supply a patch for this?
Comment #2
penguininja commentedHi marcp, I've been using the 7.x versions of OG and Context and they're looking pretty stable. A D7 port of this would be great. Thanks!
Comment #3
nasso commentedsubscribe
Comment #4
danielm commentedsubscribe
Comment #5
paulap commentedComment #6
penguininja commentedRestoring title.
Comment #7
henrijs.seso commentedI am watching presentation now at http://www.archive.org/details/OrganicGroups7 and it looks like OG has undergone some massive changes. Wonder how easy will it be to catch up.
So what functionality shall we make for this module?
Conditions could probably be:
- Group node type*
- Role in group (member, administrator, god, ...)
- Membership status (not a member, pending member, member)
...(what else?)
Reactions could be:
...(ideas?)
* 1) Groups can be any entity, not only nodes, so investigate how that changes condition setup 2) Should we have this at all, since there is node type conditio (probably yes, see (1))
Comment #8
capnjav commentedLooking forward to a port to drupal 7.. If a financial contribution would help towards this endeavour, please message me - though my budget is limited, I am certainly happy to help.
Comment #9
vegardjo commentedsub
Comment #10
emdash commentedsub
Comment #11
bruitism commentedHi,
this is my first patch to drupal.org. This is a port to D7 and OG7 (I haven been using RC4).
The only thing I'm not too happy about is the calling order of the hooks for the context and reaction (see TODO in context_og.module) - maybe someone has a better suggestion (the old hook_init() version did not work).
Best
Stephen
Comment #13
kika commentedSame patch, less whitespace
Comment #14
tekken commentedThe patches fail. What version is this made for?
Comment #15
bruitism commentedHas been tried and tested on drupal 7.7 with context 7.x-3.0-beta1 and OG 7.x-1.1-rc3.
Comment #16
tekken commentedThe patch worked against context og 6.x-3.0-beta1.
Comment #17
marcp commented@kika or anyone else who has successfully applied the patch. Could someone please re-roll the patch against master in git? I'd like to get a 7.x branch created based on this patch, but I need it to apply cleanly with git apply.
I'm getting:
Thanks!
Comment #18
kika commentedMy patch is against master. Exctract from related .make for D7:
Comment #19
marcp commented@kika, there were some differences between 6.x-3.x and master so I merged 6.x-3.x into master this morning which is probably why the patch is failing now. If you're able to re-roll against master that'd help me get this in there quicker.
Thanks for the patch, by the way!
Comment #20
bruitism commentedRebased against the latest master.
UPDATE:
this patch does not seem to work anymore. don't apply. have to investigate.
Comment #21
spacereactor commented#20 any update?
Comment #22
JamesSharpe commentedsubscribe
Comment #23
donquixote commentedsub
Comment #24
othermachines commentedSeems to work so far (applied against 6.x-dev), but it's early days. Thanks-
Comment #25
bkildow commentedI was getting whitespace errors in #20, here is a reroll against 6.x-3.x with whitespace fixes. This appears to be working for me.
Comment #26
jon pughLooks good to me.
Comment #27
jgraham commentedPatch in comment 25 applies cleanly to master and appears to be working without issues or warnings.
Setting RTBC as others have indicated the patch is working.
Comment #28
Anonymous (not verified) commentedPatched #25 with 6.x-3.x-dev (2011-Feb-25) and context version 7.x-3.0-beta2.
Cleaned the info file from "the information added by drupal.org packaging script ...." (was not done by the patch #25).
After enable this module in the module list it results in a WSOD and the error:
Fatal error: Call to undefined function og_context() in /home/public_html/drupal-7/sites/all/modules/context_ogIs 6.x-3.x-dev (2011-Feb-25) the correct version to patch from?
Comment #29
jgraham commentedcmseasy I applied the patch in comment #25 against master and that worked for me.
Comment #30
lahode commentedHi,
I tried to install the patch. The first time it worked great.
Then after a second install, I had the following error:
Fatal error: Call to undefined function og_context() in /srv/www/9028_cepp/sites/all/modules/intradf/context_og/context_og.module on line 87
I search for this og_context() function but couldn't find it. Any ideas where it is?
Thanks
Comment #31
lahode commentedOk, found it, it was in og_context module
You should add in context_og.info
Cheers
Comment #32
mrfelton commentedPatch from #25 with the extra dependency line from #31
Comment #33
mrfelton commentedRevides patch - I've removed the dependency on og_views. I'm pretty sure thats not required.
Comment #34
Anonymous (not verified) commentedTested patch #32 against master: first impression is ok!
Comment #35
jgraham commentedCommited patch 33