Hi,
One of the content editors at my workplace had tried to create a context and he had put a slash in as the name. Upon creation of the context, however, he found that he could no longer edit it (it would give him a page not found). What I see is that the context name is passed in as part of the url and my guess would be that since each slash is seen as a separate argument, context does not see it in this case. So it seems that having a check that there are no slashes (or converting the slashes to dashes or something else) seems like a good check to do.
Will post patch once I start looking through the module on this aspect.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | context_name_validation_check_btmash_1218116_3.patch | 960 bytes | btmash |
| #2 | context-validation-pdoexception.png | 81.29 KB | btmash |
Comments
Comment #1
muschpusch commentedpatch would be great! Until then you can delete / rename the record in context table...
Comment #2
btmash commentedYep, that is precisely what I did. I'm a bit confused as I try to figure out where the validation takes place. I see the function
context_ui_edit_name_validatebut didn't see it actually run. Trying to insert a second context with the same name caused a PDOException to occur. Seems like this might be a larger issue?Attaching pic.
Comment #3
btmash commentedOk, it seems like the error stemmed from the fact that the isset() check on the validation was missing being NOT isset. I also added in the $form parameter that is defined in the forms_api_reference. Patch needs review but from what I see, this now actually performs validation and also gets rid of the pdoexception. Marking at high priority due to the type of bug and behavior on 'duplicate' name.
Comment #4
febbraro commentedThis is a duplicate of #1141394: Context Allows / character in machine names which breaks: add, edit, delete, and export Already fixed in git.