Hi,
First, thanks for this nice module, it smoothens the experience for anonymous users.

I have a little feature request.
I have a small blog with one registered user (me) and anonymous users that can post comments.
When an anonymous user comments, the cached page is cleared, as desired.
But when I reply on a comment (as user 1), the cached page is not cleared, so anonymous users don't see my comment for a while.
I suspect that this is intended, to limit the cache flushing:

function content_refresh_comment($a1, $op) {
  ...
  if ($nid !== false && 0 === $uid) {
    ...
    // delete cache entries for that url
    cache_clear_all($url, 'cache_page');
  }
}

But could the check for $uid == 0 be made optional?

Comments

yaph’s picture

yaph commented
Assigned: Unassigned » yaph

This change seems to make perfect sense. Actually, I don't see a reason to make this an option but to remove the user check altogether, since the main purpose of this module is to give immediate feedback to not logged in users.

yaph’s picture

yaph commented
Status: Active » Needs review

I removed the user check and added a general setting on whether commenting shall trigger deletion of the corresponding page cache entry. The default is that the cache will be cleared, as it was before the change. Please have a look at the changes in commit http://drupal.org/cvs?commit=327522 and give your feedback.

soxofaan’s picture

soxofaan commented
Status: Needs review » Fixed

works for me, thanks!

yaph’s picture

yaph commented

Feature is in release 6.x-1.6 http://drupal.org/node/712922

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.