Problem/Motivation

The core version 8.3.3 comes updates the workflows module as well. Because of there we get an error while getting the initial state value in NotificationInformation::getTransition().

Proposed resolution

Use $workflow->getTypePlugin()->getInitialState($workflow, $entity) instead of $workflow->getInitialState().

CommentFileSizeAuthor
#4 interdiff-2885397-3-4.txt709 bytesakozma
#4 content_moderation_notifications-update-getinitialstate-2885397-4-8.x-2.x.patch1.7 KBakozma
#3 content_moderation_notifications-update-getinitialstate-2885397-3-8.x-2.x.patch1.88 KBakozma

Comments

akozma created an issue. See original summary.

akozma’s picture

akozma commented
Title: Adjust the usage of ` corresponding to 8.3.3 » Adjust the usage of getInitialState corresponding to 8.3.3
akozma’s picture

akozma commented
StatusFileSize
new content_moderation_notifications-update-getinitialstate-2885397-3-8.x-2.x.patch1.88 KB

I'm not sure how can I get the initial state value when the node is just created. Our call (hook_insert) is executed after the entity object is updated, so by using the "Save and Publish" option the status is TRUE and based on that the getInitialState returns "published".

The patch adds the condition "$entity->original == NULL" but the "$previous_state = 'draft';" is still hardcoded now.

Any ideas?

akozma’s picture

akozma commented
StatusFileSize
new content_moderation_notifications-update-getinitialstate-2885397-4-8.x-2.x.patch1.7 KB
new interdiff-2885397-3-4.txt709 bytes

Small fix on coding standards.

akozma’s picture

akozma commented
Status: Active » Needs review
rob holmes’s picture

rob holmes commented

Thanks for this, our upgrade window is tomorrow so i should get a chance to look at this then.

  • Rob Holmes committed 0b9620f on 8.x-2.x authored by akozma 
    Issue #2885397 by akozma: Adjust the usage of getInitialState...
rob holmes’s picture

rob holmes commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.