Links to other records in the repository need to be %-encoded.

See this page:
http://struct.jesandco.org/conStruct/view/?uri=http%3A%2F%2Fpurl.org%2FA...

...the links to other records currently look like this (e.g. subject):
http://struct.jesandco.org/conStruct/view/?uri=http://purl.org/ASN/scheme/ASNTopic/theArts&dataset=http://struct.jesandco.org/wsf/datasets/26/

This link won't resolve. The correct link should be %-encoded:
http://struct.jesandco.org/conStruct/view/?uri=http%3A%2F%2Fpurl.org%2FASN%2Fscheme%2FASNTopic%2FtheArts&dataset=http%3A%2F%2Fstruct.jesandco.org%2Fwsf%2Fdatasets%2F49%2F

Comments

jonphipps’s picture

jonphipps commented

Apparently it's not that simple. For instance, this link resolves just fine...
http://struct.jesandco.org/conStruct/view/?uri=http://purl.org/ASN/resou...

fgiasson’s picture

fgiasson commented
Priority: Normal » Minor

This is related to the templates. Apparently this is the default template that is shipped with the conStruct package, so the owl_thing.html template should be fixed to encode these URIs.

we should leverage the {php}...{/php} Smarty tags to use the urlencode() PHP function to do this encoding.

fgiasson’s picture

fgiasson commented

Everything depends on the URI that is not encoded. If you have a URI without characters such as "?" and "&", it should works perfect. Otherwise, you will have problems. In any case, these URIs should *always* be encoded (see my other response).

mkbergman’s picture

mkbergman commented

I agree Jon (jonphipps) this is an important issue. Given how well you and Fred have worked these issues, I think it is appropriate you become a co-maintainer for the conStruct module. If you'd like to assume that role, you have my public support to join our team.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

FYI, I approved jonphipps's application.

fgiasson’s picture

fgiasson commented
Status: Active » Closed (fixed)

Fixed in the latest commit.