Obey the coding standards!

Which standards are not taken into account?

At first glance: http://drupal.org/coding-standards#naming

Hi Joann!

Thanks, but more precisely, could you point me out to some faulty code? I think (except if I missed one) the naming conventions are took into account, so some help would be needed by pointing out some of the issues, and the reason why it is against what I can read in the standard document.

Thanks!

Take care,

Fred

Well I know the capital "S" thing is supposed to be a no no (and it's given me problems in the past with other modules). Also, as mentioned in the other issue, not naming your functions properly is also against the conventions. As for the rest, I would run your code through http://drupal.org/project/coder -- it will catch just about anything else described in the standards page.

Without knowing exactly to what fago was referring, I'm not sure what else to recommend.

[edit: fixed url]

Hi again,

Great, thanks for the pointer to the coder module (make sure the URL is ok: http://drupal.org/project/coder). About the functions, I was wondering since I think all of them were prefixed with the modules' name. However, I will probably find the issues with the Coder module.

Haaa, right about the capital "S" in the "conStruct_" prefix. I didn't notice it (well, I write it everywhere, in all sites and documentation documents, so I was probably blind to it). But right, it is a no no, and probably push the branding a little bit too far ;)

So, thanks for this answer, I will look into it when time will permit in the following days/weeks.

Won't fix for now.