Our automated tests are failing for our committed code, and therefore, we can't test / commit any patches.

https://qa.drupal.org/pifr/test/316978

Handler: ImageStyleConfiguration (TestImageStyleConfiguration) [Configuration]	39	9	2
					
					
Message	Group	Filename	Line	Function	Status
Image style successfully created.	Other	TestImageStyleConfiguration.test	100	TestImageStyleConfiguration->createConfigToExport()	
Failed to set field new to image_resize	Other	TestImageStyleConfiguration.test	104	TestImageStyleConfiguration->createConfigToExport()	
Found the Add button	Other	TestImageStyleConfiguration.test	104	TestImageStyleConfiguration->createConfigToExport()	
Found the requested form fields at 	Other	TestImageStyleConfiguration.test	104	TestImageStyleConfiguration->createConfigToExport()	
Failed to set field data[width] to 100	Other	TestImageStyleConfiguration.test	109	TestImageStyleConfiguration->createConfigToExport()	
Failed to set field data[height] to 100	Other	TestImageStyleConfiguration.test	109	TestImageStyleConfiguration->createConfigToExport()	
Found the Add effect button	Other	TestImageStyleConfiguration.test	109	TestImageStyleConfiguration->createConfigToExport()	
Found the requested form fields at 	Other	TestImageStyleConfiguration.test	109	TestImageStyleConfiguration->createConfigToExport()	
Raw "The image effect was successfully applied." found	Other	TestImageStyleConfiguration.test	110	TestImageStyleConfiguration->createConfigToExport()	
Invalid argument supplied for foreach()	Warning	ImageStyleConfiguration.php	112	Drupal\configuration\Config\ImageStyleConfiguration->prepareBuild()	
Invalid argument supplied for foreach()	Warning	ImageStyleConfiguration.php	112	Drupal\configuration\Config\ImageStyleConfiguration->prepareBuild()	

Comments

benjy’s picture

Is anyone working on this? It's been nearly 2 months.

benjy’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new1.93 KB

OK the main problem was that image_style required a label as well as the machine name.

I also fixed the "Array to String conversion" exceptions in ConfigurationHandlerBaseTestCase by using var_export. It seems you have ways to pretty print on export but does that matter for tests?

Would be great to get a review so we can get this in and re-run the tests on any other patches in the queue.

dagmar’s picture

Status: Needs review » Fixed

Thanks! I never was able to fix this issue because I couldn't replicate it locally. Commited and Pushed to 7.x-2.x.

Test are pasing again. Thanks @benjy!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.