Hi!

Congrats on the module. He is excellent.

Just a few coding standards improvements.

Thanks.

Img

CommentFileSizeAuthor
#3 coding_standards-2833766-3.patch2.63 KBcebasqueira
#2 config_share-codingstandards-2833766-2.patch1.33 KBrenatog
A.png45.26 KBrenatog

Comments

renatog created an issue. See original summary.

renatog’s picture

renatog commented
Assigned: renatog » Unassigned
Status: Active » Needs review
StatusFileSize
new config_share-codingstandards-2833766-2.patch1.33 KB

Patch submitted with the fixes.

Thanks.

Regards.

cebasqueira’s picture

cebasqueira commented
StatusFileSize
new coding_standards-2833766-3.patch2.63 KB

small fix on patch

renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community

It's good for me.

Thank you very much @cebasqueira.

Regards.

jacobbell84’s picture

jacobbell84 commented
Status: Reviewed & tested by the community » Fixed

Looks good, thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.