Closed (fixed)
Project:
Configuration installer
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Aug 2016 at 17:07 UTC
Updated:
22 Sep 2018 at 08:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
ashwinshAdded patch for this. Please review it.
Thank you,
Comment #3
grimreaperHello,
Thanks for the first patch.
I changed the type in the patch to be drupal-profile and not drupal-module.
Thanks for the review.
Comment #4
MixologicThis is the only standalone installation profile that is hosted on drupal.org. Since the project was created as a distribution, and the composer facade does not currently process distributions, config_installer is not able to be found via the composer facade.
In order to support just this one install profile, I'd like to change the module type to project_module instead of project_distribution.
However, without this composer.json that has Grimreaper's type: set to drupal-profile, it will still think its a module, so we need to get this committed first, then we can switch the project type, and then people will be able to add this install profile with composer.
The composer.json looks good to me.
Comment #5
alexpottBut if this is listed as a module then drush dl would put it in the wrong place. This ain't no module :)
Comment #6
MixologicVery good point.
Its not really a distribution either, but yeah, it should stay a distribution as I found the code that does figure out what it is, and labels it properly. We'll leave it as is.
The composer.json is valid, in this case, but not entirely necessary. Project composer actually handles the metadata for this correctly already, all I had to do was run it.
Comment #7
heddn@Mixologic, based on your findings in #2715505: Re-process config_installer metadata, is this still RTBC ready?
Comment #8
MixologicHmm. I mean, yes its RTBC ready, but it wont affect the composer facade. I.e. it can either be closed (wont fix) *or* RTBC. Its up to the maintainer whether or not they want this composer.json in there. When we get to the point where we process bare composer.json's that are not associated with a .info file or a .info.yml file, then we'll use whatever is in this composer.json to override what we're already extracting from the drupal database. In most cases that isnt at all necessary unless the maintainer wants to express a dependency on a composer library that isnt part of d.o.
Comment #9
alexpottI'm not against adding a composer.json but I'm just concerned about support for profiles.
@Mixologic can you confirm that
Will treated correctly by all the things and result in the profile being added to DRUPAL_ROOT . '/profiles'
Comment #10
jurgenhaasSo, I've tested this with
composer require drupal/config_installerand it ended up in the correct directory for profiles even though there hasn't been any composer.json available. This seem to confirm, that Drupal's packager is providing the correct information already, probably from interpreting the info.yml file. Can you confirm @Mixologic?Comment #11
gpap commentedPlease add branch-alias too for dev-master. See:
Tried to install as composer require drupal/config_installer:dev-master and it says: https://getcomposer.org/doc/articles/aliases.md#branch-alias
Also: #2885523: Create new release as version 1.5
Comment #12
Mixologic@gpap there is no master branch for drupal modules, so dev-master isnt going to be supported with drupal projects because there is essentially more than one master branch per git repository repository.
Comment #13
alexpott