Problem/Motivation

At the moment only short messages are supported.

In our case we need to have a title and a description.

Proposed resolution

We can add a description field or change the current message from string to text_long.

Full text element on edit:

Example:

CommentFileSizeAuthor
#3 conditional_messages long text.png96.29 KBmpp
#3 conditional_messages long text message.png143.31 KBmpp
#2 3065624_2.patch1.57 KBmpp

Comments

mpp created an issue. See original summary.

mpp’s picture

mpp commented
Assigned: mpp » Unassigned
Status: Active » Needs review
StatusFileSize
new 3065624_2.patch1.57 KB
mpp’s picture

mpp commented
Issue summary: View changes
StatusFileSize
new conditional_messages long text message.png143.31 KB
new conditional_messages long text.png96.29 KB
ducktape’s picture

ducktape commented
Status: Needs review » Reviewed & tested by the community
wranvaud’s picture

wranvaud commented
Version: 8.x-1.x-dev » 8.x-1.0-alpha5
Status: Reviewed & tested by the community » Needs work

This is great! I love it! However there's some styling required to provide an out-of-the-box experience. The WYSIWYG introduces HTML tags by default that break the message (mainly margins). We should provide a nice experience for people who do not want to code.
Also, the "x" button is not aligned correctly in the message, even though it's not introduced by this patch it would be great to fix this too.
I hope to have some time to fix this and once I do I'll commit your patch.
For the time being I'm marking this as needs work.

wranvaud’s picture

wranvaud commented
Status: Needs work » Fixed

Patch committed! Thanks again for your contributions!

  • wranvaud committed 529f944 on 8.x-1.x authored by mpp 
    Issue #3065624 by mpp: Support long text messages

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.