The README has a node alias and the instructions for configuration could use enhancement.

Patch to follow. Thanks!

CommentFileSizeAuthor
#5 interdiff-2895615-2-5.txt1.01 KBvolkswagenchick
#5 conditional_message-fix-readme-2895615-5.patch2.63 KBvolkswagenchick
#2 conditional_message-fix-readme-2895615-2.patch3.01 KBvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Issue summary: View changes
StatusFileSize
new conditional_message-fix-readme-2895615-2.patch3.01 KB

I have uploaded a patch with some fixes including more useful configuration and replacing a node alias.

I hope this addresses comment #5 in https://www.drupal.org/node/2895370

Thanks!!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
wranvaud’s picture

wranvaud commented
Status: Needs review » Needs work
Issue tags: +Documentation, +readme

Thanks again for your efforts on this!

Could you please leave the longer version of the introduction (lines 7 - 11 of the original readme)?
Also the documentation for installing drupal7 modules is on this URL: https://www.drupal.org/docs/7/extending-drupal-7/installing-drupal-7-con....
Finally I noticed an error on the original README, "#page-wrapper" should be "body".

Can you update the patch please?

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs work » Needs review
StatusFileSize
new conditional_message-fix-readme-2895615-5.patch2.63 KB
new interdiff-2895615-2-5.txt1.01 KB

Great! Thanks for the feedback on the patch. I have uploaded a patch with your suggestions.

I kept the link to installing Drupal 7 modules to the permalink. I feel more secure using permalinks, as node aliases can change over time. Let me know if you want me to use the node-alias and I can make a new patch.

I also uploaded an interdiff between the two patches for your convenience.

wranvaud’s picture

wranvaud commented
Status: Needs review » Needs work

Ok got it, good point, in that case the link for the D7 module installation instructions should be https://www.drupal.org/node/895232.
All the rest looks good!

wranvaud’s picture

wranvaud commented
Status: Needs work » Fixed

I was eaget to get this through tonight and already finished.
Patch commited, thank you for your contribution!

  • volkswagenchick authored 6d2445b on 7.x-1.x 
    Issue #2895615 by volkswagenchick: Replace node alias in README and add...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.