Problem/Motivation

When the target field is multiple checkboxes and condition is required then all the checkboxes are being required while expected output should be if any of the checkbox is selected then it should not throw an error while saving form saying that rest of the checkboxes are also required.

Steps to reproduce

  1. Create a field with type list (text) and field setting allowed number of values to unlimited
  2. Create condition where target is above created field and condition is required.
  3. When condition is met all the checkboxes are being required, so if we select one checkbox and try to submit form still we get an error remaining checkboxes are required
CommentFileSizeAuthor
#12 3165898-12.patch4.64 KBsaurabh-2k17
#11 3165898-10.patch3.03 KBsaurabh-2k17
#9 3165898-9.patch2.8 KBtim@lammar.be
#8 3165898-8.patch2.69 KBtim@lammar.be
Screenshot 2020-08-18 at 7.49.11 PM.png40.91 KBanand.toshniwal93

Comments

anand.toshniwal93 created an issue. See original summary.

anand.toshniwal93’s picture

anand.toshniwal93 commented
Title: If target field multiple checkbox and condition is required then all checkboxes are being required. » If target field is multiple checkbox and condition is required then all checkboxes are being required.
anand.toshniwal93’s picture

anand.toshniwal93 commented
Version: 8.x-1.x-dev » 8.x-1.0-alpha9
kris77’s picture

kris77 commented

Same issue...

mastap’s picture

mastap commented
Status: Active » Needs work

Same issue here. Unusable.

mastap’s picture

mastap commented
Version: 8.x-1.0-alpha9 » 4.0.0-alpha1

Same issue with latests: Bug Applies to 4.0.0-alpha1 released 20 May 2021 as well.

By the way, even if ALL checkboxes are checked, the field never validate.

kris77’s picture

kris77 commented

any news on this issue?

tim@lammar.be’s picture

tim@lammar.be commented
StatusFileSize
new 3165898-8.patch2.69 KB

I got it working using the attached patch.
JS: I see if there is a <legend> field in the target, meaning it's a list of checkboxes, and then apply the required class there. (Also added support for vertical tabs)
Module file: in the module file I noticed that the condition gets added to the first option of the list, rather then the whole widget. Put in a little fix for that and the serverside validation works correct.

tim@lammar.be’s picture

tim@lammar.be commented
StatusFileSize
new 3165898-9.patch2.8 KB

update: only add required state to widget if it is a 'multiple' field (parent is int, the id of the term)

saurabh-2k17’s picture

saurabh-2k17 commented
Assigned: Unassigned » saurabh-2k17
saurabh-2k17’s picture

saurabh-2k17 commented
Status: Needs work » Needs review
StatusFileSize
new 3165898-10.patch3.03 KB

The above patch was not getting applied as it was not created correctly. Also, there are some changes in the latest 4.0.0-alpha2 version of the module.

I have attached a working patch.

Thanks

saurabh-2k17’s picture

saurabh-2k17 commented
StatusFileSize
new 3165898-12.patch4.64 KB

I found that the above patch does not add the * sign on the top of the field to display as it a required field. This patch will fix that issue as well.

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented

Patch on #12 works for me.

szhu’s picture

szhu commented
Status: Needs review » Reviewed & tested by the community

  • saurabh-2k17 authored 3256b32a on 4.x 
    Issue #3165898 by saurabh-2k17: If target field is multiple checkbox...
saurabh-2k17’s picture

saurabh-2k17 commented

Thank you everyone for your support.

saurabh-2k17’s picture

saurabh-2k17 commented
Status: Reviewed & tested by the community » Fixed
paulabeatriz03’s picture

paulabeatriz03 commented

Patch not working on 4.0.0-alpha2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.