We are trying to enable the module on the comment form that also has a TinyMCE WYSIWYG editor. The label for the text area hovers in the button array. (We are using 6.x on this project, but assuming that this effects all versions)

So is it possible to either:

a) Have a blacklist of form fields to ignore
b) Integrate with WYSIWYG to enable / disable per format

Cheers

CommentFileSizeAuthor
#13 interdiff-1267244-7-13.txt1.62 KBSutharsan
#13 compact_forms-field-exclusion-1267244-13.patch2.12 KBSutharsan
#13 compact_forms-field-exclusion-1267244-13.png46.02 KBSutharsan
#7 compact_forms-field-exclusion-1267244-7.patch2 KBitaine
#3 compact_forms-field-exclusion-1267244-3.patch2.11 KBAlan D.
#1 compact_forms-field-exclusion-1267244-1.patch2.11 KBAlan D.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Active » Needs review
FileSize
compact_forms-field-exclusion-1267244-1.patch2.11 KB

This was trivial, so here is the patch.

Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
Title: WYSIWYG support / integration » Individual field exclusions
Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
FileSize
compact_forms-field-exclusion-1267244-3.patch2.11 KB

A small cross-platform error with JQuery inArray:

// UNIX only line endings, no split on MAC and trailing \r on windows
+  $blacklist = explode("\n", variable_get('compact_forms_excluded_fields' , ''));
// So this covers windows, unix and macs
+  $blacklist = preg_split("/\r\n|\n|\r/", variable_get('compact_forms_excluded_fields' , ''));
eL’s picture

eL CreditAttribution: eL commented

compact_forms-field-exclusion-1267244-3.patch - TESTED and working fine.

itaine’s picture

itaine CreditAttribution: itaine commented

@sun/tomsun - Why hasn't this patch been committed? It works well. Helps to exclude Mollom's captcha field, etc.

Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
Status: Needs review » Reviewed & tested by the community

From #4 & #5 marking as Reviewed & tested

itaine’s picture

itaine CreditAttribution: itaine commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
FileSize
compact_forms-field-exclusion-1267244-7.patch2 KB

#3 is for 6.x-1.x-dev

Re-rolling for 7.x-1.x-dev.

Marko B’s picture

Marko B CreditAttribution: Marko B commented
Priority: Normal » Critical

This is still not in DEV version, why is this so?

Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
Priority: Critical » Normal

Critical is for something that is crashing the site badly / loss of data / security issues.
Major is for something that is really badly broken.

So bumping back down...

Marko B’s picture

Marko B CreditAttribution: Marko B commented

In my case it was crashing the site badly, Visually :-) as compact forms appeared over math question in captcha and that looked bad. Anyway this works fine, should be in dev at least.

FiNeX’s picture

FiNeX CreditAttribution: FiNeX commented

The patch works fine, thanks !

robertstaddon’s picture

robertstaddon CreditAttribution: robertstaddon commented

Thanks for the patch! Can we somehow get it into the DEV version?

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan commented
Status: Reviewed & tested by the community » Needs review
FileSize
compact_forms-field-exclusion-1267244-13.png46.02 KB
compact_forms-field-exclusion-1267244-13.patch2.12 KB
interdiff-1267244-7-13.txt1.62 KB

As first time user of this patch, I found the position of the textarea in the form not logical. It is an exception on the first input and is therefore closely related to that field. I decided to move the "Excluded Field CSS IDs" field below the "Form CSS IDs" field.

The description of the field did not inform me enough. I tried the field wrapper ID and tried the field ID. The latter worked correctly, the first did not. I changed the description of the field to better describe which IDs to enter. See screenshot.

compact_forms-field-exclusion-1267244-13.png

druvision’s picture

druvision CreditAttribution: druvision commented

#7 works. +1 for committing it.

#13 only contains one of the files so it may only be checked after #7 is installed.

ropic’s picture

ropic CreditAttribution: ropic commented
Issue summary: View changes

My solution

form.compact-form label[for=edit-captcha-response]{
top: 2em;
}

nickonom’s picture

nickonom CreditAttribution: nickonom commented

Patch in #13 worked just as expected. RTBC.

nickonom’s picture

nickonom CreditAttribution: nickonom commented
Status: Needs review » Reviewed & tested by the community

Please commit the patch as it give the module very needed functionality.