Unsupported stripe payment method types leave orders stuck in cart (while paid in Stripe)

I created an initial draft of how this COULD look like. The implementation is not ideal, as currently the plugin ids don't match the external names. Furthermore I am not 100% sure, whether there is a payment method type for each payment method currently supported (e.g. I couldn't find a "google_pay" method type, even though it should be supported) or if there are payment method types that add support for multiple payment methods.

But what I AM sure about is, that we DEFINITLY need to remove the "automatic_payment_methods" key from the payment intent. The module currently misses a LOT of payment method types and to force the commerce_stripe admin user to check the code, which payment method types are actually supported, to only activate these payment method types in the stripe dashboard is really really bad...

Here is a quick description of "automatic_payment_methods":

When you enable this parameter, this PaymentIntent accepts payment methods that you enable in the Dashboard and that are compatible with this PaymentIntent’s other parameters.

(https://docs.stripe.com/api/payment_intents/create?api-version=2024-06-20)

Here a quick screenshot of the output of "getSupportedStripePaymentMethodTypes()":

Here is a list of all supported stripe payment method types:

$payment_method_types = [
    'acss_debit',
    'affirm',
    'afterpay_clearpay',
    'alipay',
    'amazon_pay',
    'au_becs_debit',
    'bacs_debit',
    'bancontact',
    'blik',
    'boleto',
    'card',
    'card_present',
    'cashapp',
    'customer_balance',
    'eps',
    'fpx',
    'giropay',
    'grabpay',
    'ideal',
    'interac_present',
    'klarna',
    'konbini',
    'link',
    'mb_way',
    'mobilepay',
    'multibanco',
    'nz_bank_account',
    'oxxo',
    'p24',
    'paynow',
    'paypal',
    'pix',
    'promptpay',
    'revolut_pay',
    'sepa_debit',
    'sofort',
    'sunbit',
    'swish',
    'twint',
    'us_bank_account',
    'wechat_pay',
    'zip'
];

(https://docs.stripe.com/api/payment_methods/object#payment_method_object...)

@anybody and I thought, that we could add a new "StripePaymentMethodTypeInterface" method called "getStripePaymentMethodTypeId()" or something like that, which simply returns the stripe payment method type id.

We go over that list and create an array of supported payment method types, which we then pass to the payment intent.

As a bonus, we could also show a list of the supported payment methods (and for a bonus bonus, we could also make them checkboxes to enable / disable the types on Drupal's site in addition to enabling / disabling them via the stripe UI).

@anybody / @grevil,

Did attempt to do something similar to what you are proposing.

Have you tested the inverse, though, or only the happy path?

If you pass a list of payment methods, rather than using automatic, and you pass "PayPal" from the Drupal side, and it is not enabled on the Stripe side, you get an exception and cannot check out. (Maybe they no longer do this, which would then make this more viable?)

I do have other thoughts to resolve this, but one would work with MySQL, but not MariaDB. (And would require a dependency on another contrib module.). It could be simplified so that it would work on both, but then would have views implications.

Trade-offs abound, unfortunately.

The ideal current solution is to get more payment method types implemented, but that hasn't happened as fast as we'd like.

This is documented, though, if you read the module documentation, linked on the home page. Here is the deep link: https://docs.drupalcommerce.org/v2/user-guide/payment/integrations/strip...

A few other notes on this:

1. If you could configure them in both the site AND stripe, you just know people will say "I turned it on in Drupal, but it isn't showing up" (because it isn't turned on in Stripe). and vice versa. (That is also not taking into account all the other combinations that can occur. e.g. it is turned on in both Drupal AND Stripe...but the dollar amount is too small for that payment method. or the customer doesn't have GooglePay/ApplePay configured on their laptop, etc...)

2. Relating to another ticket asking about being able to reorder the payment methods, Stripe states "Unless your integration requires a code-based option for offering payment methods, Stripe recommends the automated option. This is because Stripe evaluates the currency, payment method restrictions, and other parameters to determine the list of supported payment methods. Payment methods that increase conversion and that are most relevant to the currency and customer’s location are prioritized."

3. IRT the mapping of stripe payment methods to drupal ones, the 2 outliers are Google Pay and Apple Pay. Stripe lists them as separate payment methods in their customer UX, but in their API, they are part of the card payment method...except when invoking payment_method_types when creating a payment intent...you instead have to specify them in the javascript element to exclude them, if you are using the card element.

4. If you do have a specific use case for a particular site, you could subscribe the StripeEvents::PAYMENT_INTENT_CREATE event, and modify the payment intent before it is created.

@tomtech

If you pass a list of payment methods, rather than using automatic, and you pass "PayPal" from the Drupal side, and it is not enabled on the Stripe side, you get an exception and cannot check out. (Maybe they no longer do this, which would then make this more viable?)

Interestingly enough I didn't get an exception, the order just went trough using "PayPal", even though it is disabled. Which is definitly not optimal either. Best would be, if both "automatic_payment_methods" is enabled and "payment_method_types" could be passed, so that we are using a subset of the payment method types enabled in stripe.

Stripe currently already implements a similiar feature, where both "automatic_payment_methods" and "exclude_payment_method_types" can be passed. But this isn't feasible in the context of this module (as we would need to maintain a list of all payment method types supported by stripe).
I will create a ticket for the stripe support in which I'll ask if they would add support for allowing both "automatic_payment_methods" and "payment_method_types" to allow support of a subset of the enabled payment method types.

For the time being, we should at least add a list of currently supported payment method types by the module. Later on, we could switch this setting to a checkboxes form element to allow a subset of the supported method types.

Setting this to "Needs Review" for the Payment Method Type list.

This is what it looks like: