Problem/Motivation

When using express checkout from cart, if the order type doesn't have "Enable shipping for this order type" checked, the dialogs still pop up asking for for you to select a shipping address but display errors like "Invalid shipping address." for Google pay or "Something went wrong: This order can't be shipped to your shipping address. Please check your address and try again" for Amazon pay.

Produces errors on the backend too

Location	 /commerce-stripe/express-checkout/shipping-address-change/149
Referrer	/cart

Drupal\Core\Entity\EntityStorageException: Missing bundle for entity type commerce_shipment in Drupal\Core\Entity\ContentEntityStorageBase->doCreate() (line 132 of /web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php).
#0 /web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(101): Drupal\Core\Entity\ContentEntityStorageBase->doCreate()
#1 /web/modules/contrib/commerce_stripe/src/Controller/ExpressCheckoutController.php(162): Drupal\Core\Entity\ContentEntityStorageBase->create()
#2 [internal function]: Drupal\commerce_stripe\Controller\ExpressCheckoutController->onShippingAddressChange()
#3 /web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
#4 /web/core/lib/Drupal/Core/Render/Renderer.php(634): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->{closure:Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber::wrapControllerExecutionInRenderContext():121}()
#5 [internal function]: Drupal\Core\Render\Renderer::{closure:Drupal\Core\Render\Renderer::executeInRenderContext():634}()
#6 /web/core/lib/Drupal/Core/Render/Renderer.php(635): Fiber->start()
#7 /web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext()
#8 /web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
#9 /vendor/symfony/http-kernel/HttpKernel.php(183): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->{closure:Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber::onController():96}()
#10 /vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#11 /web/core/lib/Drupal/Core/StackMiddleware/Session.php(53): Symfony\Component\HttpKernel\HttpKernel->handle()
#12 /web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#13 /web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#14 /web/core/modules/page_cache/src/StackMiddleware/PageCache.php(118): Drupal\Core\StackMiddleware\ContentLength->handle()
#15 /web/core/modules/page_cache/src/StackMiddleware/PageCache.php(92): Drupal\page_cache\StackMiddleware\PageCache->pass()
#16 /web/modules/contrib/crawler_rate_limit/src/CrawlerRateLimitMiddleware.php(55): Drupal\page_cache\StackMiddleware\PageCache->handle()
#17 /web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\crawler_rate_limit\CrawlerRateLimitMiddleware->handle()
#18 /web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#19 /web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(53): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#20 /web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(54): Drupal\Core\StackMiddleware\AjaxPageState->handle()
#21 /web/core/lib/Drupal/Core/DrupalKernel.php(745): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
#22 /web/index.php(19): Drupal\Core\DrupalKernel->handle()
#23 {main}

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

generalredneck created an issue. See original summary.

generalredneck’s picture

Issue summary: View changes