The hook was temporary, and for the next release we need to replace it with conditions + an event.
Just like payment gateways have conditions + a FilterPaymentGatewaysEvent.

CommentFileSizeAuthor
#2 alter_hook_replaced_by_event-2898137-2.patch9.81 KBtilenav
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

tilenav’s picture

tilenav CreditAttribution: tilenav at Agiledrop - Your Trusted Drupal Teammates commented
Status: Active » Needs review
FileSize
alter_hook_replaced_by_event-2898137-2.patch9.81 KB

This patch contains replacement of hook by event and test for filtering shipping methods.

tilenav’s picture

tilenav CreditAttribution: tilenav at Agiledrop - Your Trusted Drupal Teammates commented

Created a pull request on github repo: https://github.com/drupalcommerce/commerce_shipping/pull/2

maaty388’s picture

maaty388 CreditAttribution: maaty388 commented
Status: Needs review » Reviewed & tested by the community

I tested the patch and it applies perfectly

  • bojanz committed 00f4c49 on 8.x-2.x authored by tilenav 
    Issue #2898137 by tilenav, bojanz: Replace...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Reviewed & tested by the community » Fixed

Thanks! Tweaked and committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.