Total amount of selected products comparison error [#2395421]

Have upgraded 2.1, but unable to get the rules working. Worked brilliantly previously in 1.3 with the original Compare product amount condition. Tested the dev version a few weeks back, but saw that was still buggy with the notices appearing, so reverted back and waited, and this new version isn't working for me still.

I’m trying to create a series of rules for flat rate shipping for orders that contain a particular product type (Order contains products of particular product types) and between total order value ranges of those product types (Total amount of selected products comparison) e.g. under £5, between £5.01 - £20.00 and so on etc to set the shipping rate to the total value amount in order of product type.

Rules are still evaluating to false in debug, and getting ‘no shipping rates found for your order’, and also getting the notice when using Total amount of selected products comparison condition

“Warning: trim() expects parameter 1 to be string, array given in commerce_rules_extra_compare_product() (line 80 of … commerce_rules_extra/includes/conditions/commerce_rules_extra_compare_product_quantity.inc).”

(I did full upgrade as per instructions on upgrade.txt too, and rebuilt all my rule components from scratch that use this module). I’ve tested with adding Term Reference etc in the Total amount of selected products comparison condition and no joy there either (If I add term reference I get the following message above still and also more which mentions line 91 of that file.) but presume that as not using Terms for this condition, I wouldn't need to add those anyhow.

Quantity rule is fine btw as tested with that, no errors appearing, but that’s not the one I need to be using as it’s the value amount not quantity of products; and have looked through some of the issues here re the notices on the earlier dev versions too.

Any ideas or suggestions?

Comment	File	Size	Author
#21	2395421-product-amount-calculation-func-params-21.patch	1.13 KB	Anonymous (not verified)
#19	2395421-product-amount-calculation-func-params-19.patch	989 bytes	Anonymous (not verified)
#18	Screen Shot 2015-01-28 at 12.04.50 PM.png	46.39 KB	Anonymous (not verified)
#3	2395421-product-amount-calculation-func-params-3.patch	2.58 KB	Anonymous (not verified)

Comments

Comment #1

blackroom commented 18 December 2014 at 16:03

I've also found that I wasn't getting the predicted result with this same condition – 'Total amount of selected products comparison'. I've just come fresh to this module as I was looking to trigger an action when a product of a certain type had a value amount of more than 1. Uninstalling this and installing 1.3 using 'Total product of type amount value comparison' (which I'm guessing is the equivalent?) with the same operator/amount gave me the result I expected.

Comment #2

perignon commented 18 December 2014 at 17:37

Assigned:

Unassigned

» perignon

I'll review the issue as soon as I can!

Comment #3

Anonymous (not verified) commented 22 January 2015 at 01:39

Status	File	Size
new	2395421-product-amount-calculation-func-params-3.patch	2.58 KB

I believe I've fixed the issue. It looks like the parameters got mixed up. Things appear to be working as they should be here (I'm able to use the conditions without error now).

Comment #4

Anonymous (not verified) commented 22 January 2015 at 01:39

Status:

Active

» Needs review

Comment #5

perignon commented 22 January 2015 at 05:14

Hopefully some other people can get this patch tested that is using that rule. I myself don't have the rule being used in a production site.

Comment #6

lswhitehead commented 22 January 2015 at 09:11

I'll be able to test this in the coming week, and will let you know. Thanks!

Comment #7

blackroom commented 22 January 2015 at 13:54

I'll check this one too over the next couple of days and report back

Comment #8

perignon commented 22 January 2015 at 14:46

Thanks everyone!

Comment #9

blackroom commented 24 January 2015 at 19:29

I've applied the patch successfully and re-created the rule using the new version of the module. I've created a rule with the condition 'Total amount of selected products comparison' that should be true if the cart contains products of type 'product' with a combined value of zero. However, if I checkout a product of that type that's worth 0.00 it's still returning false in the debug. I've attached an export of the rule incase I'm missing something when creating the comparable rule based on the slightly altered options in the newer version. The total quantity options work fine.

{ "rules_product_has_no_shipping" : {
    "LABEL" : "Product has no shipping",
    "PLUGIN" : "reaction rule",
    "REQUIRES" : [ "commerce_rules_extra" ],
    "ON" : [ "commerce_rules_extra_process_checkout_pane" ],
    "IF" : [
      { "commerce_rules_extra_compare_product_amount" : {
          "order" : [ "commerce-order" ],
          "product_type" : { "value" : { "product" : "product" } },
          "exclude" : 0,
          "operator" : "=",
          "value" : "0",
          "term_id" : { "value" : [] },
          "product_display" : 0,
          "term_operator" : "IOO"
        }
      }
    ],
    "DO" : [
      { "commerce_rules_extra_change_pane" : {
          "pane_id" : "commerce_shipping",
          "page_id" : "\u003Csame\u003E",
          "enabled" : 0
        }
      }
    ]
  }
}

Comment #10

perignon commented 24 January 2015 at 18:43

Thanks for the feedback. I will take a look at it sometime this weekend.

FYI, when you paste code into the comments it is helpful to use the code text format, makes spacing work right for readability.

Comment #11

blackroom commented 24 January 2015 at 19:30

Sorry about that (updated above)

Comment #12

lswhitehead commented 28 January 2015 at 11:13

I've given it a test, not getting the notice now, but still false in debug and 'no shipping rates found for your order'.

Comment #13

perignon commented 28 January 2015 at 16:19

Sorry for taking so long to look into this. The patch doesn't actually do anything submitted above, but just rearrange the function calls. No logic is changed.

Comment #14

Anonymous (not verified) commented 28 January 2015 at 16:31

Right, this only really affects the trim() error that was occurring due to miss-ordered parameters.

I'll boot up a commerce install and try out each of them to make sure they're working as advertised.

Comment #15

perignon commented 28 January 2015 at 16:32

I got to look into this more but at the moment I just started a new project and my dev environment is hosed writing new custom fields and content types...

Comment #16

perignon commented 28 January 2015 at 16:52

@mhazy, that's the thing. I double checked the order and it was right.

Comment #17

perignon commented 28 January 2015 at 16:54

Just did a triple check. The order is correct.

Comment #18

Anonymous (not verified) commented 28 January 2015 at 17:10

Status	File	Size
new	Screen Shot 2015-01-28 at 12.04.50 PM.png	46.39 KB

The order of parameters is not correct in commerce_rules_extra_compare_product_amount() for the "Total amount of selected product comparison" condition.

Product type and vocabulary are switched. The other methods that I changed in the original patch were superfluous. I'll re-create it with the pertinent bits.

/**
 * Callback function for Compare Product Amount condition.
 */
function commerce_rules_extra_compare_product_amount($order, $voc_name, $term_ids, $product_display, $require_all, $product_type, $exclude, $operator, $value) {
  return commerce_rules_extra_compare_product($order, $voc_name, $term_ids, $product_display, $require_all, $product_type, $exclude, $operator, $value, "amount");
}

Compared to commerce_rules_extra_compare_product_quantity(), where the product type is the second argument.

/**
 * Callback function for Compare Product Quantity.
 *
 * Calculates the quantity of products in an order that have the term $term_id
 * and compares it to a given value.
 */
function commerce_rules_extra_compare_product_quantity($order, $product_type, $exclude, $operator, $value, $voc_name, $term_id, $product_display, $term_operator) {
  return commerce_rules_extra_compare_product($order, $voc_name, $term_id, $product_display, $term_operator, $product_type, $exclude, $operator, $value, 'quantity');
}

Comment #19

Anonymous (not verified) commented 28 January 2015 at 17:13

Status	File	Size
new	2395421-product-amount-calculation-func-params-19.patch	989 bytes

1 file was hidden/shown/deleted

Status	File	Size
hidden	2395421-product-amount-calculation-func-params-3.patch	2.58 KB

Updated patch

Comment #20

Anonymous (not verified) commented 28 January 2015 at 17:47

1 file was hidden/shown/deleted

Status	File	Size
hidden	Screen Shot 2015-01-28 at 12.04.50 PM.png	46.39 KB

Jumped the gun a bit, it actually looks like the two groups of parameters are switched.

Based on how the parameters are defined in commerce_rules_extra_compare_product_quantity_condition_info() the order of arguments for commerce_rules_extra_compare_product_amount() should be:

$order
$product_type
$exclude
$operator
$value
$voc_name
$term_ids
$product_display
$operator

Comment #21

Anonymous (not verified) commented 28 January 2015 at 18:39

Status	File	Size
new	2395421-product-amount-calculation-func-params-21.patch	1.13 KB

This patch sorts out the function arguments.

Comment #22

28 January 2015 at 19:49

Perignon committed e2842ed on 7.x-2.x authored by mhazy

Issue #2395421 by mhazy: Total amount of selected products comparison...

Needs review

» Fixed

Comment #28

11 March 2015 at 17:34

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Total amount of selected products comparison error