See reports generated by upgrade_status:


CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Commerce Reporting
Scanned on Jul 15, 2021.

3 warnings found.

web/modules/contrib/commerce_reports/src/EventSubscriber/OrderPlacedEventSubscri
ber.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 73   │ Parameter $event of method                                   │
│ manually │      │ Drupal\commerce_reports\EventSubscriber\OrderPlacedEventSubs │
│          │      │ criber::generateReports() has typehint with deprecated class │
│          │      │ Symfony\Component\HttpKernel\Event\PostResponseEvent: since  │
│          │      │ Symfony 4.3, use TerminateEvent instead                      │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_reports/tests/src/Kernel/OrderReportGenerationTest.
php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │ 110  │ Instantiation of deprecated class                           │
│ manually │      │ Symfony\Component\HttpKernel\Event\PostResponseEvent: since │
│          │      │ Symfony 4.3, use TerminateEvent instead                     │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

web/modules/contrib/commerce_reports/commerce_reports.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Value of core_version_requirement: ^8.8 || ^9 is not       │
│ manually │      │ compatible with the next major version of Drupal core. See │
│          │      │ https://drupal.org/node/3070687.                           │
│          │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

Also, EntityManager is deprecated, which is replaced by EntityTypeManager

Comments

skyredwang created an issue. See original summary.

skyredwang’s picture

Assigned: skyredwang » Unassigned
Status: Active » Needs review
StatusFileSize
new7.17 KB
skyredwang’s picture

Issue summary: View changes
mglaman’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll
nels’s picture

StatusFileSize
new3.95 KB

Here's that re-roll.

nels’s picture

StatusFileSize
new5.56 KB

Trying again, includes code style updates reported in tests.

nels’s picture

StatusFileSize
new8.86 KB

Hopefully catching all the test declarations

nels’s picture

StatusFileSize
new10.3 KB
nels’s picture

Status: Needs work » Needs review
simgui8’s picture

Most of this has landed in rc1.
3167290

And for the TerminateEvent, I have made a MR 325571

I will leave it open and try to reach maintainers.

Thanks skyredwang and Nels

jsacksick’s picture

Status: Needs review » Needs work

Not sure what's still relevant in the patch, it clearly needs a reroll due to the recent changes.

However:

public function generateReports(TerminateEvent $event) { cannot change right now as this would mean dropping Drupal 8 compatibility.

jsacksick’s picture

Status: Needs work » Closed (outdated)

This is no longer relevant, closing.