See reports generated by upgrade_status:
CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Commerce Reporting
Scanned on Jul 15, 2021.
3 warnings found.
web/modules/contrib/commerce_reports/src/EventSubscriber/OrderPlacedEventSubscri
ber.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check │ 73 │ Parameter $event of method │
│ manually │ │ Drupal\commerce_reports\EventSubscriber\OrderPlacedEventSubs │
│ │ │ criber::generateReports() has typehint with deprecated class │
│ │ │ Symfony\Component\HttpKernel\Event\PostResponseEvent: since │
│ │ │ Symfony 4.3, use TerminateEvent instead │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘
web/modules/contrib/commerce_reports/tests/src/Kernel/OrderReportGenerationTest.
php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check │ 110 │ Instantiation of deprecated class │
│ manually │ │ Symfony\Component\HttpKernel\Event\PostResponseEvent: since │
│ │ │ Symfony 4.3, use TerminateEvent instead │
│ │ │ │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘
web/modules/contrib/commerce_reports/commerce_reports.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check │ 0 │ Value of core_version_requirement: ^8.8 || ^9 is not │
│ manually │ │ compatible with the next major version of Drupal core. See │
│ │ │ https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴────────────────────────────────────────────────────────────┘
Also, EntityManager is deprecated, which is replaced by EntityTypeManager
Comments
Comment #2
skyredwangComment #3
skyredwangComment #4
mglamanProbably needs a reroll after #3167290: Fix tests deprecation notices and prepare commerce_reports module for Drupal 9. This has some other fixes.
Comment #5
nels commentedHere's that re-roll.
Comment #6
nels commentedTrying again, includes code style updates reported in tests.
Comment #7
nels commentedHopefully catching all the test declarations
Comment #8
nels commentedComment #9
nels commentedComment #10
simgui8 commentedMost of this has landed in rc1.
3167290
And for the TerminateEvent, I have made a MR 325571
I will leave it open and try to reach maintainers.
Thanks skyredwang and Nels
Comment #11
jsacksick commentedNot sure what's still relevant in the patch, it clearly needs a reroll due to the recent changes.
However:
public function generateReports(TerminateEvent $event) {cannot change right now as this would mean dropping Drupal 8 compatibility.Comment #12
jsacksick commentedThis is no longer relevant, closing.