Lots of the new features for the Commerce POS release on Drupal 8 list orders. A lot of the order listings require cashiers and register fields and these lists make the assumption that the field is 100% available on all order types. This is not the case and should be fixed in a follow up issue #2960807: Implicitly filter out orders from POS listings that don't have cashier or register fields..

Regardless of the "fix" this highlighted the "workaround" (which is to add these fields on other order types) is not possible because the register field is locked and cannot be added to other order bundles.

Comments

joshmiller created an issue. See original summary.

joshmiller’s picture

Issue summary: View changes
joshmiller’s picture

Assigned: joshmiller » Unassigned
Status: Active » Needs review
StatusFileSize
new1.37 KB

Status: Needs review » Needs work

The last submitted patch, 3: 2960806-02.patch, failed testing. View results

swickham’s picture

Status: Needs work » Reviewed & tested by the community

Worked for me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2960806-02.patch, failed testing. View results

joshmiller’s picture

Looking into the test problem.

joshmiller’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new24.9 KB

Test appears to be drunk, looking good by manually testing.

smccabe’s picture

The order comments test had a problem where it could run fast enough that 2 entries happened in the same second and could appear out of order, I've fixed that so tests shouldn't fail randomly anymore.

  • smccabe committed 21a1cc7 on 8.x-2.x authored by joshmiller
    Issue #2960806 by joshmiller, swickham: Unlock the field_register field...
smccabe’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.