Closed (fixed)
Project:
Commerce Discount
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 May 2013 at 00:15 UTC
Updated:
20 May 2015 at 17:38 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jwjoshuawalker commentedattaching.
Comment #2
bojanz commentedI'll commit #1893752: Make sure that redirect module does not inject redirect into discount form separately, let's roll a patch without that.
Most of the code wrapping changes need to be reverted.
Please see http://drupal.org/coding-standards#linelength
There are multiple examples of this in your patch:
We never wrap variable declarations or function calls.
Comment #3
jwjoshuawalker commentedOk :(
I wish the codesniffer were more accurate in this regard. It does not flag an issue either way. I think that is just my personal preference, but I'll take those out where appropriate.
Comment #4
jwjoshuawalker commentedHere we go.
Comment #5
vasikethe (#4) patch needs a reroll.
Comment #6
jkuma commentedThanks for the code cleanup drastik, your patch will be committed after the alpha3.
Comment #7
joelpittetRe-roll of #4
Comment #8
joelpittetThanks, fixed and committed.